[Android] AndroidMediaLibrary: Remove start() function

Hugo Beauzée-Luyssen git at videolan.org
Thu Feb 24 10:58:19 UTC 2022


vlc-android | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Mon Feb 21 13:32:56 2022 +0100| [ed867ab0499895e73fe5137a506494d86d3ccf04] | committer: Nicolas Pomepuy

AndroidMediaLibrary: Remove start() function

This function doesn't exist anymore in the medialibrary and doesn't need
a binding

> https://code.videolan.org/videolan/vlc-android/commit/ed867ab0499895e73fe5137a506494d86d3ccf04
---

 medialibrary/jni/AndroidMediaLibrary.cpp                         | 9 ---------
 medialibrary/jni/AndroidMediaLibrary.h                           | 1 -
 medialibrary/jni/medialibrary.cpp                                | 7 -------
 medialibrary/src/org/videolan/medialibrary/MedialibraryImpl.java | 2 --
 4 files changed, 19 deletions(-)

diff --git a/medialibrary/jni/AndroidMediaLibrary.cpp b/medialibrary/jni/AndroidMediaLibrary.cpp
index c804778c2..a54c83c16 100644
--- a/medialibrary/jni/AndroidMediaLibrary.cpp
+++ b/medialibrary/jni/AndroidMediaLibrary.cpp
@@ -14,7 +14,6 @@
 
 static pthread_key_t jni_env_key;
 static JavaVM *myVm;
-static bool m_started = false;
 
 static void jni_detach_thread(void *data)
 {
@@ -55,14 +54,6 @@ AndroidMediaLibrary::initML()
     return p_ml->initialize(this);
 }
 
-void
-AndroidMediaLibrary::start()
-{
-//    p_ml->start();
-    m_started = true;
-}
-
-
 bool
 AndroidMediaLibrary::clearDatabase(bool restorePlaylists) {
     return p_ml->clearDatabase(restorePlaylists);
diff --git a/medialibrary/jni/AndroidMediaLibrary.h b/medialibrary/jni/AndroidMediaLibrary.h
index 2511fa8e1..c751e17ff 100644
--- a/medialibrary/jni/AndroidMediaLibrary.h
+++ b/medialibrary/jni/AndroidMediaLibrary.h
@@ -31,7 +31,6 @@ public:
     ~AndroidMediaLibrary();
 
     medialibrary::InitializeResult initML();
-    void start();
     bool isDeviceKnown(const std::string& uuid, const std::string& path, bool removable);
     bool deleteRemovableDevices();
     void addDevice(const std::string& uuid, const std::string& path, bool removable);
diff --git a/medialibrary/jni/medialibrary.cpp b/medialibrary/jni/medialibrary.cpp
index 7003b513f..144622ede 100644
--- a/medialibrary/jni/medialibrary.cpp
+++ b/medialibrary/jni/medialibrary.cpp
@@ -41,12 +41,6 @@ init(JNIEnv* env, jobject thiz, jstring dbPath, jstring thumbsPath)
     return (int) initCode;
 }
 
-void
-start(JNIEnv* env, jobject thiz)
-{
-    MediaLibrary_getInstance(env, thiz)->start();
-}
-
 void
 release(JNIEnv* env, jobject thiz)
 {
@@ -2021,7 +2015,6 @@ regroup(JNIEnv* env, jobject thiz, jlong id)
   */
 static JNINativeMethod methods[] = {
     {"nativeInit", "(Ljava/lang/String;Ljava/lang/String;)I", (void*)init },
-    {"nativeStart", "()V", (void*)start },
     {"nativeRelease", "()V", (void*)release },
     {"nativeClearDatabase", "(Z)Z", (void*)clearDatabase },
     {"nativeAddDevice", "(Ljava/lang/String;Ljava/lang/String;Z)V", (void*)addDevice },
diff --git a/medialibrary/src/org/videolan/medialibrary/MedialibraryImpl.java b/medialibrary/src/org/videolan/medialibrary/MedialibraryImpl.java
index 8eb8b0c4b..fa6b0cd34 100644
--- a/medialibrary/src/org/videolan/medialibrary/MedialibraryImpl.java
+++ b/medialibrary/src/org/videolan/medialibrary/MedialibraryImpl.java
@@ -95,7 +95,6 @@ public class MedialibraryImpl extends Medialibrary {
     @Override
     public void start() {
         if (isStarted()) return;
-        nativeStart();
         isMedialibraryStarted = true;
         synchronized (onMedialibraryReadyListeners) {
             for (OnMedialibraryReadyListener listener : onMedialibraryReadyListeners) listener.onMedialibraryReady();
@@ -600,7 +599,6 @@ public class MedialibraryImpl extends Medialibrary {
 
     // Native methods
     private native int nativeInit(String dbPath, String thumbsPath);
-    private native void nativeStart();
     private native void nativeRelease();
 
     private native boolean nativeClearDatabase(boolean keepPlaylist);



More information about the Android mailing list