[Android] PlayerOption: fix VideoControls not visible

Duncan McNamara git at videolan.org
Wed Jan 19 09:23:18 UTC 2022


vlc-android | branch: master | Duncan McNamara <dcn.mcnamara at gmail.com> | Fri Jan 14 11:48:27 2022 +0100| [c8c95a990ef4e8a78a9ed7ab772905c1ec8b930a] | committer: Duncan McNamara

PlayerOption: fix VideoControls not visible

When showing player options for the first time since starting the
player, the video specific options were not visible due to updating the
option list before add the video options to the list. Updates to the
list are now after adding the video options.

> https://code.videolan.org/videolan/vlc-android/commit/c8c95a990ef4e8a78a9ed7ab772905c1ec8b930a
---

 .../src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt b/application/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt
index 32c20d553..b1724b3d6 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/helpers/PlayerOptionsDelegate.kt
@@ -105,7 +105,6 @@ class PlayerOptionsDelegate(val activity: FragmentActivity, val service: Playbac
         options.add(PlayerOption(ID_SAVE_PLAYLIST, R.drawable.ic_addtoplaylist, res.getString(R.string.playlist_save)))
         if (service.playlistManager.player.canDoPassthrough() && settings.getString("aout", "0") == "0")
             options.add(PlayerOption(ID_PASSTHROUGH, R.drawable.ic_passthrough, res.getString(R.string.audio_digital_title)))
-        (recyclerview.adapter as OptionsAdapter).update(options)
         if (!Settings.showTvUi) {
             if (video) {
             options.add(PlayerOption(ID_VIDEO_CONTROLS_SETTING, R.drawable.ic_video_controls, res.getString(R.string.controls_setting)))
@@ -116,6 +115,7 @@ class PlayerOptionsDelegate(val activity: FragmentActivity, val service: Playbac
             options.add(PlayerOption(ID_SHOW_PLAYLIST_TIPS, R.drawable.ic_playlisttips, res.getString(R.string.playlist_tips)))
             }
         }
+        (recyclerview.adapter as OptionsAdapter).update(options)
     }
 
     fun show() {



More information about the Android mailing list