[Android] Accessibility: improve talkback for onboarding

Nicolas Pomepuy git at videolan.org
Fri Jun 3 11:30:22 UTC 2022


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Wed Jun  1 13:25:06 2022 +0200| [937d073df5de662bfdd427be86f509d37f251fff] | committer: Nicolas Pomepuy

Accessibility: improve talkback for onboarding

> https://code.videolan.org/videolan/vlc-android/commit/937d073df5de662bfdd427be86f509d37f251fff
---

 application/resources/src/main/res/values/strings.xml      | 1 +
 application/vlc-android/res/layout/activity_onboarding.xml | 1 +
 application/vlc-android/res/layout/onboarding_theme.xml    | 3 +++
 3 files changed, 5 insertions(+)

diff --git a/application/resources/src/main/res/values/strings.xml b/application/resources/src/main/res/values/strings.xml
index d9bed6bd9..1aa3b878b 100644
--- a/application/resources/src/main/res/values/strings.xml
+++ b/application/resources/src/main/res/values/strings.xml
@@ -297,6 +297,7 @@
     <string name="screen_orientation_landscape_reverse">Landscape reverse</string>
     <string name="screen_orientation_last_locked">Last locked orientation</string>
     <string name="enable_black_theme">Black theme</string>
+    <string name="theme_auto">Auto theme</string>
     <string name="subtitle_text_encoding">Subtitle text encoding</string>
     <string name="subtitle_preferred_language">Preferred subtitle language</string>
     <string name="daynight_title">DayNight mode</string>
diff --git a/application/vlc-android/res/layout/activity_onboarding.xml b/application/vlc-android/res/layout/activity_onboarding.xml
index b187390ae..5457decf5 100644
--- a/application/vlc-android/res/layout/activity_onboarding.xml
+++ b/application/vlc-android/res/layout/activity_onboarding.xml
@@ -22,6 +22,7 @@
             android:layout_marginStart="8dp"
             android:layout_marginTop="8dp"
             android:background="?attr/selectableItemBackgroundBorderless"
+            android:contentDescription="@string/close"
             android:padding="8dp"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="parent"
diff --git a/application/vlc-android/res/layout/onboarding_theme.xml b/application/vlc-android/res/layout/onboarding_theme.xml
index eb74d18d6..77f7f1c4e 100644
--- a/application/vlc-android/res/layout/onboarding_theme.xml
+++ b/application/vlc-android/res/layout/onboarding_theme.xml
@@ -13,6 +13,7 @@
             android:layout_height="wrap_content"
             android:layout_marginStart="16dp"
             android:background="@drawable/theme_selection_rounded"
+            android:contentDescription="@string/theme_auto"
             android:padding="16dp"
             app:layout_constraintBottom_toBottomOf="@+id/lightTheme"
             app:layout_constraintEnd_toStartOf="@+id/lightTheme"
@@ -36,6 +37,7 @@
             android:padding="16dp"
             android:scaleX="0.8"
             android:scaleY="0.8"
+            android:contentDescription="@string/light_theme"
             app:layout_constraintBottom_toTopOf="@+id/textView5"
             app:layout_constraintEnd_toStartOf="@+id/darkTheme"
             app:layout_constraintHorizontal_bias="0.5"
@@ -54,6 +56,7 @@
             android:layout_height="wrap_content"
             android:layout_marginEnd="16dp"
             android:padding="16dp"
+            android:contentDescription="@string/enable_black_theme"
             android:scaleX="0.8"
             android:scaleY="0.8"
             app:layout_constraintBottom_toBottomOf="@+id/lightTheme"



More information about the Android mailing list