[Android] Settings: fix media db dump on devices < A11

[Duncan McNamara]

vlc-android | branch: master | Duncan McNamara <dcn.mcnamara at gmail.com> | Wed Jun 22 11:47:32 2022 +0200| [4fae111cbddc8af1c547cf85f13e05417f274457] | committer: Nicolas Pomepuy

Settings: fix media db dump on devices < A11

On devices lower than Android 11, the hasAllAccess will usually be true,
but they need the WRITE_EXTERNAL_STORAGE to be able to write. Because of
this, the dump database is started, but then fails because they dont
have write permission

Fixes #2547

> https://code.videolan.org/videolan/vlc-android/commit/4fae111cbddc8af1c547cf85f13e05417f274457
---

 application/vlc-android/src/org/videolan/vlc/util/Permissions.kt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/util/Permissions.kt b/application/vlc-android/src/org/videolan/vlc/util/Permissions.kt
index 044d00d4f..768598f00 100644
--- a/application/vlc-android/src/org/videolan/vlc/util/Permissions.kt
+++ b/application/vlc-android/src/org/videolan/vlc/util/Permissions.kt
@@ -97,7 +97,9 @@ object Permissions {
 
     @JvmOverloads
     fun canWriteStorage(context: Context = AppContextProvider.appContext): Boolean {
-        return hasAllAccess(context) || ContextCompat.checkSelfPermission(context,
+        return if (AndroidUtil.isROrLater) {
+            hasAllAccess(context)
+        } else ContextCompat.checkSelfPermission(context,
                 Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED
     }