[Android] Fix favorite icon placement in audio items
Nicolas Pomepuy
git at videolan.org
Fri Nov 18 12:29:45 UTC 2022
vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon Nov 14 08:48:37 2022 +0100| [5ddaf503a52757f43764c890f5f5554b907e3260] | committer: Nicolas Pomepuy
Fix favorite icon placement in audio items
> https://code.videolan.org/videolan/vlc-android/commit/5ddaf503a52757f43764c890f5f5554b907e3260
---
.../vlc-android/res/layout/audio_browser_item.xml | 100 ++++++++++-----------
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/application/vlc-android/res/layout/audio_browser_item.xml b/application/vlc-android/res/layout/audio_browser_item.xml
index 019822509c..e17783e306 100644
--- a/application/vlc-android/res/layout/audio_browser_item.xml
+++ b/application/vlc-android/res/layout/audio_browser_item.xml
@@ -130,58 +130,58 @@
vlc:layout_constraintStart_toStartOf="@+id/selector_image"
vlc:layout_constraintTop_toTopOf="@+id/selector_image" />
- <ImageView
- android:id="@+id/network_media"
+ <LinearLayout
+ android:id="@+id/linearLayout6"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:padding="3dp"
- android:visibility="@{isNetwork ? View.VISIBLE : View.GONE}"
+ android:orientation="vertical"
vlc:layout_constraintBottom_toBottomOf="parent"
- vlc:layout_constraintEnd_toStartOf="@id/item_more"
- vlc:layout_constraintTop_toBottomOf="@+id/media_favorite"
- vlc:srcCompat="@drawable/ic_emoji_network" />
-
- <ImageView
- android:id="@+id/sd_media"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:padding="3dp"
- android:visibility="@{isSD ? View.VISIBLE : View.GONE}"
- vlc:layout_constraintEnd_toStartOf="@id/item_more"
- vlc:layout_constraintTop_toTopOf="@+id/network_media"
- vlc:srcCompat="@drawable/ic_emoji_sd" />
-
- <ImageView
- android:id="@+id/otg_media"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:padding="3dp"
- android:visibility="@{isOTG ? View.VISIBLE : View.GONE}"
- vlc:layout_constraintEnd_toStartOf="@id/item_more"
- vlc:layout_constraintTop_toTopOf="@+id/network_media"
- vlc:srcCompat="@drawable/ic_emoji_otg" />
-
- <ImageView
- android:id="@+id/network_media_off"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:padding="3dp"
- android:visibility="@{!isPresent ? View.VISIBLE : View.GONE}"
- vlc:layout_constraintEnd_toStartOf="@id/item_more"
- vlc:layout_constraintTop_toTopOf="@+id/network_media"
- vlc:srcCompat="@drawable/ic_emoji_absent" />
-
- <ImageView
- android:id="@+id/media_favorite"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:padding="3dp"
- android:visibility="@{isFavorite ? View.VISIBLE : View.GONE}"
- vlc:layout_constraintBottom_toTopOf="@+id/network_media"
- vlc:layout_constraintEnd_toStartOf="@id/item_more"
- vlc:layout_constraintTop_toTopOf="parent"
- vlc:layout_constraintVertical_chainStyle="packed"
- vlc:srcCompat="@drawable/ic_emoji_favorite" />
+ vlc:layout_constraintEnd_toStartOf="@+id/item_more"
+ vlc:layout_constraintTop_toTopOf="parent">
+
+ <ImageView
+ android:id="@+id/media_favorite"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:padding="3dp"
+ android:visibility="@{isFavorite ? View.VISIBLE : View.GONE}"
+ vlc:srcCompat="@drawable/ic_emoji_favorite" />
+
+ <ImageView
+ android:id="@+id/network_media"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:padding="3dp"
+ android:visibility="@{isNetwork ? View.VISIBLE : View.GONE}"
+ vlc:srcCompat="@drawable/ic_emoji_network" />
+
+ <ImageView
+ android:id="@+id/sd_media"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:padding="3dp"
+ android:visibility="@{isSD ? View.VISIBLE : View.GONE}"
+ tools:visibility="gone"
+ vlc:srcCompat="@drawable/ic_emoji_sd" />
+
+ <ImageView
+ android:id="@+id/otg_media"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:padding="3dp"
+ android:visibility="@{isOTG ? View.VISIBLE : View.GONE}"
+ tools:visibility="gone"
+ vlc:srcCompat="@drawable/ic_emoji_otg" />
+
+ <ImageView
+ android:id="@+id/network_media_off"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:padding="3dp"
+ android:visibility="@{!isPresent ? View.VISIBLE : View.GONE}"
+ tools:visibility="gone"
+ vlc:srcCompat="@drawable/ic_emoji_absent" />
+ </LinearLayout>
<ImageView
android:id="@+id/selector_image"
@@ -212,7 +212,7 @@
android:singleLine="false"
vlc:asyncText="@{item.title}"
vlc:layout_constraintBottom_toTopOf="@+id/subtitle"
- vlc:layout_constraintEnd_toStartOf="@+id/media_favorite"
+ vlc:layout_constraintEnd_toStartOf="@+id/linearLayout6"
vlc:layout_constraintStart_toEndOf="@+id/media_cover"
vlc:layout_constraintTop_toTopOf="parent"
vlc:layout_constraintVertical_chainStyle="packed"
More information about the Android
mailing list