[Android] Fix a regression showing an unwanted icon on file browser cards

Nicolas Pomepuy git at videolan.org
Tue Sep 6 05:52:45 UTC 2022


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Tue Sep  6 07:34:35 2022 +0200| [52a9ac98bdfb9e297ffc38c5462bc808c18f1ecd] | committer: Nicolas Pomepuy

Fix a regression showing an unwanted icon on file browser cards

> https://code.videolan.org/videolan/vlc-android/commit/52a9ac98bdfb9e297ffc38c5462bc808c18f1ecd
---

 application/vlc-android/res/layout/card_browser_item.xml | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/application/vlc-android/res/layout/card_browser_item.xml b/application/vlc-android/res/layout/card_browser_item.xml
index ed8218f78..7de62f5bc 100644
--- a/application/vlc-android/res/layout/card_browser_item.xml
+++ b/application/vlc-android/res/layout/card_browser_item.xml
@@ -102,21 +102,16 @@
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="parent" />
 
+            <!-- It's just a place holder. Should never be shown-->
             <ImageView
                     android:id="@+id/item_ban"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_marginEnd="8dp"
-                    android:background="?attr/selectableItemBackgroundBorderless"
-                    android:clickable="@{hasContextMenu}"
-                    android:contentDescription="@string/more_actions"
-                    android:onClick="@{holder::onMoreClick}"
-                    android:padding="8dp"
-                    android:visibility="@{hasContextMenu ? View.VISIBLE : View.GONE, default=gone}"
+                    android:visibility="gone"
                     app:layout_constraintBottom_toBottomOf="parent"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="parent"
-                    app:srcCompat="@drawable/ic_more"
                     tools:visibility="visible" />
 
             <!-- Image downloading is handled by org.videolan.vlc.gui.helpers.ImageLoader.loadImage() -->



More information about the Android mailing list