[Android] Improve about screen

Nicolas Pomepuy git at videolan.org
Tue Sep 13 13:54:07 UTC 2022


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Aug 11 13:41:58 2022 +0200| [721b9ef50368c1f29a8622b3c33e476747ead804] | committer: Duncan McNamara

Improve about screen

#Fixes #2633
Fix the wrong VLC hash and add some more info

> https://code.videolan.org/videolan/vlc-android/commit/721b9ef50368c1f29a8622b3c33e476747ead804
---

 .../res/layout/dialog_about_version.xml            | 51 +++++++++++++++++++++-
 .../videolan/vlc/gui/dialogs/AboutVersionDialog.kt |  2 +
 2 files changed, 52 insertions(+), 1 deletion(-)

diff --git a/application/vlc-android/res/layout/dialog_about_version.xml b/application/vlc-android/res/layout/dialog_about_version.xml
index 9e7a5285d..92b5ee196 100644
--- a/application/vlc-android/res/layout/dialog_about_version.xml
+++ b/application/vlc-android/res/layout/dialog_about_version.xml
@@ -67,11 +67,33 @@
                     android:layout_height="wrap_content"
                     android:layout_marginStart="16dp"
                     android:layout_marginTop="4dp"
+                    android:text="libvlcjni"
+                    android:textColor="?attr/font_light"
+                    app:layout_constraintStart_toStartOf="parent"
+                    app:layout_constraintTop_toBottomOf="@+id/textView35" />
+
+            <TextView
+                    android:id="@+id/textView35"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:layout_marginStart="16dp"
+                    android:layout_marginTop="4dp"
                     android:text="VLC"
                     android:textColor="?attr/font_light"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toBottomOf="@+id/textView28" />
 
+            <TextView
+                    android:id="@+id/textView2"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:layout_marginStart="16dp"
+                    android:layout_marginTop="4dp"
+                    android:text="libvlc"
+                    android:textColor="?attr/font_light"
+                    app:layout_constraintStart_toStartOf="parent"
+                    app:layout_constraintTop_toBottomOf="@+id/textView29" />
+
             <TextView
                     android:id="@+id/textView30"
                     android:layout_width="wrap_content"
@@ -83,7 +105,8 @@
                     android:textColor="?attr/font_light"
                     app:layout_constraintBottom_toBottomOf="parent"
                     app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toBottomOf="@+id/textView29" />
+                    app:layout_constraintTop_toBottomOf="@+id/textView2"
+                    app:layout_constraintVertical_bias="1.0" />
 
             <TextView
                     android:id="@+id/revision"
@@ -103,12 +126,38 @@
                     android:layout_height="wrap_content"
                     android:layout_marginStart="24dp"
                     android:textColor="?attr/font_default"
+                    app:layout_constraintBottom_toBottomOf="@+id/textView35"
+                    app:layout_constraintEnd_toEndOf="parent"
+                    app:layout_constraintStart_toEndOf="@+id/compilation_barrier"
+                    app:layout_constraintTop_toTopOf="@+id/textView35"
+                    tools:text="cb3c6284d" />
+
+            <TextView
+                    android:id="@+id/libvlc_revision"
+                    android:layout_width="0dp"
+                    android:layout_height="wrap_content"
+                    android:layout_marginStart="24dp"
+                    android:textColor="?attr/font_default"
                     app:layout_constraintBottom_toBottomOf="@+id/textView29"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintStart_toEndOf="@+id/compilation_barrier"
                     app:layout_constraintTop_toTopOf="@+id/textView29"
                     tools:text="cb3c6284d" />
 
+            <TextView
+                    android:id="@+id/libvlc_version"
+                    android:layout_width="0dp"
+                    android:layout_height="wrap_content"
+                    android:layout_marginStart="24dp"
+                    android:textColor="?attr/font_default"
+                    app:layout_constraintBottom_toBottomOf="@+id/textView2"
+                    app:layout_constraintEnd_toEndOf="parent"
+                    app:layout_constraintHorizontal_bias="0.0"
+                    app:layout_constraintStart_toEndOf="@+id/compilation_barrier"
+                    app:layout_constraintTop_toTopOf="@+id/textView2"
+                    app:layout_constraintVertical_bias="1.0"
+                    tools:text="cb3c6284d" />
+
             <TextView
                     android:id="@+id/compiled_by"
                     android:layout_width="0dp"
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/AboutVersionDialog.kt b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/AboutVersionDialog.kt
index a0edd4c15..d8ddc386b 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/AboutVersionDialog.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/AboutVersionDialog.kt
@@ -67,6 +67,8 @@ class AboutVersionDialog : VLCBottomSheetDialogFragment() {
         binding.changelog.text = getString(R.string.changelog).replace("*", "•")
         binding.revision.text = getString(R.string.build_revision)
         binding.vlcRevision.text = getString(R.string.build_vlc_revision)
+        binding.libvlcRevision.text = getString(R.string.build_libvlc_revision)
+        binding.libvlcVersion.text = BuildConfig.LIBVLC_VERSION
         binding.compiledBy.text = getString(R.string.build_host)
     }
 



More information about the Android mailing list