[Android] PiP: set isInPipMode to false in onStop

Duncan McNamara git at videolan.org
Tue Aug 13 08:29:09 UTC 2024


vlc-android | branch: master | Duncan McNamara <dcn.mcnamara at gmail.com> | Mon Aug 12 15:59:39 2024 +0200| [9fa78fb6d8e40fa77322912857a73b760f3f5416] | committer: Nicolas Pomepuy

PiP: set isInPipMode to false in onStop

Pressing the stop / cross button on pip to stop the PiP player will stop
PiP but not set the liveData value to false. This causes StartActivity
to restart the video player when re-opening the app after killing the
pip player, and can cause the HUD not to show

> https://code.videolan.org/videolan/vlc-android/commit/9fa78fb6d8e40fa77322912857a73b760f3f5416
---

 .../vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.kt    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/application/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.kt b/application/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.kt
index 6c2a8d041a..705a5ca125 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.kt
@@ -917,6 +917,7 @@ open class VideoPlayerActivity : AppCompatActivity(), PlaybackService.Callback,
         cleanUI()
         stopPlayback()
         service?.playlistManager?.videoStatsOn?.postValue(false)
+        service?.isInPiPMode?.value = false
 
         if (savedTime != -1L) settings.putSingle(VIDEO_RESUME_TIME, savedTime)
 



More information about the Android mailing list