[Android] OpenSubtitles: remove login

Nicolas Pomepuy git at videolan.org
Thu Nov 21 13:19:11 UTC 2024


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Nov 21 13:54:19 2024 +0100| [0b0ee58f90f6c30f9ef69bf002dc89e5e6010af4] | committer: Duncan McNamara

OpenSubtitles: remove login

> https://code.videolan.org/videolan/vlc-android/commit/0b0ee58f90f6c30f9ef69bf002dc89e5e6010af4
---

 application/resources/src/main/res/values/strings.xml             | 2 +-
 application/vlc-android/res/layout/subtitle_downloader_dialog.xml | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/application/resources/src/main/res/values/strings.xml b/application/resources/src/main/res/values/strings.xml
index 5fd390f276..1418bcc4ca 100644
--- a/application/resources/src/main/res/values/strings.xml
+++ b/application/resources/src/main/res/values/strings.xml
@@ -716,7 +716,7 @@
     <string name="popup_playback">Playing in a Pop-Up window</string>
     <string name="popup_expand">Expand video</string>
     <string name="download_subtitles">Download subtitles</string>
-    <string name="powered_opensubtitles">Powered by OpenSubtitles. Remaining downloads : %s</string>
+    <string name="powered_opensubtitles">Powered by OpenSubtitles</string>
     <string name="open_subtitles_not_logged_in">You are not logged into OpenSubtitles\nLogging in will grant you access to more downloads</string>
     <string name="open_subtitles_logged_in">Logged in as %1$s</string>
     <string name="open_subtitles_limits">You have %1$s remaining downloads out of %2$s. Your limit will be reset at %3$s.</string>
diff --git a/application/vlc-android/res/layout/subtitle_downloader_dialog.xml b/application/vlc-android/res/layout/subtitle_downloader_dialog.xml
index cbcf5a8017..9176696617 100644
--- a/application/vlc-android/res/layout/subtitle_downloader_dialog.xml
+++ b/application/vlc-android/res/layout/subtitle_downloader_dialog.xml
@@ -53,7 +53,7 @@
                     android:layout_height="wrap_content"
                     android:layout_marginStart="16dp"
                     android:layout_marginEnd="16dp"
-                    android:text="@{@string/powered_opensubtitles(viewmodel.observableLimit.get().getRemainingText())}"
+                    android:text="@string/powered_opensubtitles"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toBottomOf="@+id/sub_download_history"
@@ -85,6 +85,7 @@
                     android:focusable="true"
                     android:padding="8dp"
                     android:selected="@{state == state.Login}"
+                    android:visibility="gone"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintTop_toTopOf="parent"
                     app:srcCompat="@drawable/ic_account" />



More information about the Android mailing list