[Android] Fix RTL for the bookmarks

Nicolas Pomepuy git at videolan.org
Fri Nov 22 13:53:24 UTC 2024


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Nov 14 07:17:36 2024 +0100| [be8d878f83ff576ba6612bd4cc0c5b4cf9f067cd] | committer: Nicolas Pomepuy

Fix RTL for the bookmarks

> https://code.videolan.org/videolan/vlc-android/commit/be8d878f83ff576ba6612bd4cc0c5b4cf9f067cd
---

 .../main/res/drawable-ldrtl/rectangle_circle_right_orange.xml    | 9 +++++++++
 application/vlc-android/res/layout/bookmark_item.xml             | 5 ++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/application/resources/src/main/res/drawable-ldrtl/rectangle_circle_right_orange.xml b/application/resources/src/main/res/drawable-ldrtl/rectangle_circle_right_orange.xml
new file mode 100644
index 0000000000..f24075fc66
--- /dev/null
+++ b/application/resources/src/main/res/drawable-ldrtl/rectangle_circle_right_orange.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<shape xmlns:android="http://schemas.android.com/apk/res/android"
+       android:shape="rectangle">
+    <solid android:color="@color/orange500focus"/>
+    <corners
+            android:topLeftRadius="36dp"
+            android:bottomLeftRadius="36dp"/>
+
+</shape>
\ No newline at end of file
diff --git a/application/vlc-android/res/layout/bookmark_item.xml b/application/vlc-android/res/layout/bookmark_item.xml
index d70628892a..04263a928c 100644
--- a/application/vlc-android/res/layout/bookmark_item.xml
+++ b/application/vlc-android/res/layout/bookmark_item.xml
@@ -56,7 +56,6 @@
                 android:layout_marginTop="8dp"
                 android:layout_marginEnd="16dp"
                 android:fontFamily="sans-serif-medium"
-                android:gravity="center_vertical"
                 android:maxLines="1"
                 android:singleLine="true"
                 android:text="@{bookmark.title}"
@@ -67,7 +66,6 @@
                 app:layout_constraintEnd_toStartOf="@+id/item_more"
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toTopOf="parent"
-                app:layout_constraintVertical_chainStyle="packed"
                 tools:text="Bookmark 1" />
 
         <TextView
@@ -97,7 +95,8 @@
                 android:layout_alignParentEnd="true"
                 android:layout_centerVertical="true"
                 android:layout_gravity="center"
-                android:layout_marginRight="4dp"
+                android:layout_marginEnd="4dp"
+                android:padding="8dp"
                 android:contentDescription="@string/more_actions"
                 android:background="?attr/selectableItemBackgroundBorderless"
                 android:onClick="@{(view) -> holder.onMoreClick(view, bookmark)}"



More information about the Android mailing list