[Android] Fix broken layout in the about dialog

Nicolas Pomepuy git at videolan.org
Tue Nov 26 14:31:13 UTC 2024


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Tue Nov 26 13:23:29 2024 +0100| [cf45bfa14f10fadb01aa3d2a03a21c6b48c5fd11] | committer: Duncan McNamara

Fix broken layout in the about dialog

> https://code.videolan.org/videolan/vlc-android/commit/cf45bfa14f10fadb01aa3d2a03a21c6b48c5fd11
---

 .../res/layout/dialog_about_version.xml            | 25 ++++++++++++----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/application/vlc-android/res/layout/dialog_about_version.xml b/application/vlc-android/res/layout/dialog_about_version.xml
index 40c889232a..e732526b88 100644
--- a/application/vlc-android/res/layout/dialog_about_version.xml
+++ b/application/vlc-android/res/layout/dialog_about_version.xml
@@ -62,27 +62,30 @@
                     app:layout_constraintTop_toBottomOf="@+id/changelog" />
 
             <TextView
-                    android:id="@+id/remote_access_hash_title"
+                    android:id="@+id/remote_access"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_marginStart="16dp"
-                    android:text="@string/remote_access_hash_title"
+                    android:layout_marginTop="8dp"
+                    android:text="@string/remote_access_version_title"
                     android:textColor="?attr/font_light"
-                    android:maxWidth="150dp"
-                    app:layout_constraintBottom_toBottomOf="@+id/remote_access_revision"
                     app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toBottomOf="@+id/remote_access_version" />
+                    app:layout_constraintTop_toBottomOf="@+id/divider2" />
 
             <TextView
-                    android:id="@+id/remote_access"
-                    android:layout_width="wrap_content"
+                    android:id="@+id/remote_access_hash_title"
+                    android:layout_width="0dp"
                     android:layout_height="wrap_content"
                     android:layout_marginStart="16dp"
-                    android:text="@string/remote_access_version_title"
+                    android:layout_marginTop="8dp"
+                    android:layout_marginBottom="16dp"
+                    android:text="@string/remote_access_hash_title"
                     android:textColor="?attr/font_light"
-                    app:layout_constraintBottom_toBottomOf="@+id/remote_access_version"
+                    app:layout_constraintBottom_toBottomOf="parent"
+                    app:layout_constraintEnd_toStartOf="@id/compilation_barrier"
+                    app:layout_constraintHorizontal_bias="1.0"
                     app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toTopOf="@+id/remote_access_version" />
+                    app:layout_constraintTop_toBottomOf="@+id/remote_access" />
 
             <TextView
                     android:id="@+id/textView28"
@@ -278,7 +281,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     app:barrierDirection="end"
-                    app:constraint_referenced_ids="remote_access_hash_title,remote_access,textView28,textView30,textView29" />
+                    app:constraint_referenced_ids="remote_access,textView28,textView30,textView29" />
 
 
         </androidx.constraintlayout.widget.ConstraintLayout>



More information about the Android mailing list