[Android] Refactor the forum and documentation strings
Nicolas Pomepuy
git at videolan.org
Thu Apr 24 14:06:53 UTC 2025
vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Apr 10 11:24:10 2025 +0200| [0c3225a1ec838bd9c36b8fc98fb1c0f4be0f1d47] | committer: Nicolas Pomepuy
Refactor the forum and documentation strings
> https://code.videolan.org/videolan/vlc-android/commit/0c3225a1ec838bd9c36b8fc98fb1c0f4be0f1d47
---
application/resources/src/main/res/values/strings.xml | 2 ++
application/vlc-android/src/org/videolan/vlc/gui/FeedbackActivity.kt | 4 ++--
application/vlc-android/src/org/videolan/vlc/gui/helpers/UiTools.kt | 3 ---
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/application/resources/src/main/res/values/strings.xml b/application/resources/src/main/res/values/strings.xml
index 217e4a2e31..5f651705dd 100644
--- a/application/resources/src/main/res/values/strings.xml
+++ b/application/resources/src/main/res/values/strings.xml
@@ -1401,4 +1401,6 @@
<string name="remote_access_feedback_generated_explanation">Tap the button below to send it using your default email client. If you encounter any issues, you can copy paste the fields below and send the email yourself.</string>
<string name="remote_access_feedback_file_explanation">You just downloaded the needed file. Please remember to attach it to your email.</string>
<string name="generic_copied_to_clipboard">Copied to clipboard</string>
+ <string name="forum_url" translatable="false">https://forum.videolan.org/viewforum.php?f=35</string>
+ <string name="doc_url" translatable="false">https://docs.videolan.me/vlc-user/android/</string>
</resources>
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/FeedbackActivity.kt b/application/vlc-android/src/org/videolan/vlc/gui/FeedbackActivity.kt
index 2bedf01d7c..1c9455e3d2 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/FeedbackActivity.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/FeedbackActivity.kt
@@ -186,10 +186,10 @@ class FeedbackActivity : BaseActivity(), DebugLogService.Client.Callback {
updateFormIncludesVisibility()
}
binding.feedbackForumCard.setOnClickListener {
- openLinkIfPossible("https://forum.videolan.org/viewforum.php?f=35")
+ openLinkIfPossible(getString(R.string.forum_url))
}
binding.readDocCard.setOnClickListener {
- openLinkIfPossible("https://docs.videolan.me/vlc-user/android/")
+ openLinkIfPossible(getString(R.string.doc_url))
}
binding.emailSupportSend.setOnClickListener {
if (binding.includeLogs.isChecked) {
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/helpers/UiTools.kt b/application/vlc-android/src/org/videolan/vlc/gui/helpers/UiTools.kt
index 436be9b17a..c67f97cbe6 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/helpers/UiTools.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/helpers/UiTools.kt
@@ -513,9 +513,6 @@ object UiTools {
v.findViewById<View>(R.id.about_website_container).setOnClickListener {
activity.openLinkIfPossible("https://www.videolan.org/vlc/")
}
-// v.findViewById<View>(R.id.about_forum_container).setOnClickListener {
-// activity.openLinkIfPossible("https://forum.videolan.org/viewforum.php?f=35")
-// }
v.findViewById<View>(R.id.about_report_container).setOnClickListener {
activity.startActivity(Intent(activity, FeedbackActivity::class.java))
}
More information about the Android
mailing list