[Android] Incognito: fix resume playback

Duncan McNamara git at videolan.org
Thu Feb 6 10:35:20 UTC 2025


vlc-android | branch: master | Duncan McNamara <dcn.mcnamara at gmail.com> | Mon Jan 13 16:55:07 2025 +0100| [1ff44a78068415e21ed34d92c60d46df76645ce8] | committer: Nicolas Pomepuy

Incognito: fix resume playback

In all the PlaylistManager "save" methods, incognito mode wasn't
checked.

Fixes #3125

> https://code.videolan.org/videolan/vlc-android/commit/1ff44a78068415e21ed34d92c60d46df76645ce8
---

 application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt b/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt
index 3978fef4b9..63eb27c1d7 100644
--- a/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt
+++ b/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt
@@ -740,6 +740,7 @@ class PlaylistManager(val service: PlaybackService) : MediaWrapperList.EventList
 
     @Synchronized
     fun saveCurrentMedia(forceVideo:Boolean = false) {
+        if (settings.getBoolean(KEY_INCOGNITO, false) || !settings.getBoolean(PLAYBACK_HISTORY, true)) return
         val media = getCurrentMedia() ?: return
         val isAudio = isAudioList() || forceVideo
         if (media.uri.scheme.isSchemeFD()) {
@@ -771,6 +772,7 @@ class PlaylistManager(val service: PlaybackService) : MediaWrapperList.EventList
     }
 
     suspend fun saveMediaList(forceVideo:Boolean = false) {
+        if (settings.getBoolean(KEY_INCOGNITO, false) || !settings.getBoolean(PLAYBACK_HISTORY, true)) return
         val currentMedia = getCurrentMedia() ?: return
         if (currentMedia.uri.scheme.isSchemeFD()) return
         val locations = StringBuilder()
@@ -964,6 +966,7 @@ class PlaylistManager(val service: PlaybackService) : MediaWrapperList.EventList
 
     @Synchronized
     private fun savePosition(reset: Boolean = false, video: Boolean = false) {
+        if (settings.getBoolean(KEY_INCOGNITO, false) || !settings.getBoolean(PLAYBACK_HISTORY, true)) return
         if (!hasMedia()) return
         settings.edit {
             val audio = !video && isAudioList()



More information about the Android mailing list