[Android] Remove useless permission livedata from the PermissionListDialog

[Nicolas Pomepuy]

vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon Feb 10 10:40:03 2025 +0100| [c2f2ba49bb677ab802468b6e613d8955f7d1dc5a] | committer: Nicolas Pomepuy

Remove useless permission livedata from the PermissionListDialog

> https://code.videolan.org/videolan/vlc-android/commit/c2f2ba49bb677ab802468b6e613d8955f7d1dc5a
---

 .../org/videolan/vlc/gui/browser/MainBrowserFragment.kt  |  6 ------
 .../org/videolan/vlc/gui/dialogs/PermissionListDialog.kt | 16 ----------------
 2 files changed, 22 deletions(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/gui/browser/MainBrowserFragment.kt b/application/vlc-android/src/org/videolan/vlc/gui/browser/MainBrowserFragment.kt
index 6740d3736a..12bc04ddd7 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/browser/MainBrowserFragment.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/browser/MainBrowserFragment.kt
@@ -190,12 +190,6 @@ class MainBrowserFragment : BaseFragment(), View.OnClickListener, CtxActionRecei
         val storageBrowserAdapter = BaseBrowserAdapter(storageBrowserContainer)
         localEntry.list.adapter = storageBrowserAdapter
         containerAdapterAssociation[storageBrowserContainer] = Pair(storageBrowserAdapter, localViewModel)
-        PermissionListDialog.hasAnyPermission.observe(viewLifecycleOwner) {
-            if (it) {
-                localViewModel.provider.refresh()
-                favoritesViewModel.provider.refresh()
-            }
-        }
         localViewModel.dataset.observe(viewLifecycleOwner) { list ->
             list?.let {
                 if (Permissions.canReadStorage(requireActivity())) storageBrowserAdapter.update(it)
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/PermissionListDialog.kt b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/PermissionListDialog.kt
index d3fd596f19..241924f15d 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/PermissionListDialog.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/PermissionListDialog.kt
@@ -70,8 +70,6 @@ class PermissionListDialog : VLCBottomSheetDialogFragment() {
         }
 
     companion object {
-        val hasAnyPermission = MutableLiveData<Boolean>().apply { value = false }
-
         fun newInstance(): PermissionListDialog {
             return PermissionListDialog()
         }
@@ -87,15 +85,6 @@ class PermissionListDialog : VLCBottomSheetDialogFragment() {
 
     override fun initialFocusedView(): View = binding.permissionTitle
 
-    override fun onCreate(savedInstanceState: Bundle?) {
-        refreshPermissionLiveData()
-        super.onCreate(savedInstanceState)
-    }
-
-    private fun refreshPermissionLiveData() {
-        hasAnyPermission.postValue(Permissions.hasAllAccess(requireActivity()) || Permissions.hasAnyFileFineAccess(requireActivity()))
-    }
-
     override fun onCreateView(
         inflater: LayoutInflater, container: ViewGroup?,
         savedInstanceState: Bundle?
@@ -115,11 +104,6 @@ class PermissionListDialog : VLCBottomSheetDialogFragment() {
     }
 
     private fun updateStorageState() {
-
-        refreshPermissionLiveData()
-
-        //Notification
-
         binding.notificationPermissionCheck.setImageDrawable(ContextCompat.getDrawable(requireActivity(), if (Permissions.canSendNotifications(requireActivity())) R.drawable.ic_permission_check_checked else R.drawable.ic_permission_check_unchecked))
         binding.notificationPermissionContainer.setOnClickListener {
             if (Permissions.canSendNotifications(requireActivity())) {