[Android] Remove obsolete playback speed settings
Nicolas Pomepuy
git at videolan.org
Fri Feb 14 13:01:40 UTC 2025
vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Feb 13 14:53:22 2025 +0100| [5089ee7521485562312b3fbb5ed2d70ed456df45] | committer: Duncan McNamara
Remove obsolete playback speed settings
> https://code.videolan.org/videolan/vlc-android/commit/5089ee7521485562312b3fbb5ed2d70ed456df45
---
application/resources/src/main/res/values/strings.xml | 2 --
.../java/org/videolan/television/ui/preferences/PreferencesAudio.kt | 3 ---
.../java/org/videolan/television/ui/preferences/PreferencesVideo.kt | 4 ----
application/vlc-android/res/xml/preferences_audio.xml | 6 ------
application/vlc-android/res/xml/preferences_video.xml | 6 ------
.../src/org/videolan/vlc/gui/preferences/PreferencesAudio.kt | 3 ---
.../src/org/videolan/vlc/gui/preferences/PreferencesVideo.kt | 3 ---
7 files changed, 27 deletions(-)
diff --git a/application/resources/src/main/res/values/strings.xml b/application/resources/src/main/res/values/strings.xml
index e02bb10f8b..6288f90413 100644
--- a/application/resources/src/main/res/values/strings.xml
+++ b/application/resources/src/main/res/values/strings.xml
@@ -243,8 +243,6 @@
<string name="audio_resume_playback_title">Audio play queue history</string>
<string name="audio_resume_playback_warning">Disabling the audio play queue history may lead to some behavior issues.\nAfter disabling it you may not be able to resume the playback from:\n\n\t- a bluetooth device\n\t- the widget\n\t- the media notification</string>
<string name="audio_resume_playback_summary">Allow saving the audio play queue to resume later</string>
- <string name="playback_speed_title">Save Playback Speed</string>
- <string name="playback_speed_summary">Keep playback speed between media</string>
<string name="play_button">Play Button</string>
diff --git a/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesAudio.kt b/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesAudio.kt
index 62b5a67459..39b29f9c44 100644
--- a/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesAudio.kt
+++ b/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesAudio.kt
@@ -42,8 +42,6 @@ import kotlinx.coroutines.launch
import org.videolan.libvlc.util.AndroidUtil
import org.videolan.resources.VLCInstance
import org.videolan.tools.AUDIO_DUCKING
-import org.videolan.tools.KEY_PLAYBACK_RATE
-import org.videolan.tools.KEY_PLAYBACK_SPEED_PERSIST
import org.videolan.tools.LocaleUtils
import org.videolan.tools.RESUME_PLAYBACK
import org.videolan.tools.Settings
@@ -174,7 +172,6 @@ class PreferencesAudio : BasePreferenceFragment(), SharedPreferences.OnSharedPre
} else launch { restartLibVLC() }
}
}
- KEY_PLAYBACK_SPEED_PERSIST -> sharedPreferences.putSingle(KEY_PLAYBACK_RATE, 1.0f)
}
}
diff --git a/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesVideo.kt b/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesVideo.kt
index 009b9808f0..1036719c95 100644
--- a/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesVideo.kt
+++ b/application/television/src/main/java/org/videolan/television/ui/preferences/PreferencesVideo.kt
@@ -31,8 +31,6 @@ import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.MainScope
import kotlinx.coroutines.launch
import org.videolan.resources.VLCInstance
-import org.videolan.tools.KEY_PLAYBACK_RATE_VIDEO
-import org.videolan.tools.KEY_PLAYBACK_SPEED_PERSIST_VIDEO
import org.videolan.tools.LOCK_USE_SENSOR
import org.videolan.tools.POPUP_FORCE_LEGACY
import org.videolan.tools.SAVE_BRIGHTNESS
@@ -77,8 +75,6 @@ class PreferencesVideo : BasePreferenceFragment(), SharedPreferences.OnSharedPre
restartMediaPlayer()
}
}
-
- KEY_PLAYBACK_SPEED_PERSIST_VIDEO -> sharedPreferences.putSingle(KEY_PLAYBACK_RATE_VIDEO, 1.0f)
}
}
}
diff --git a/application/vlc-android/res/xml/preferences_audio.xml b/application/vlc-android/res/xml/preferences_audio.xml
index 2092823435..aa62b12511 100644
--- a/application/vlc-android/res/xml/preferences_audio.xml
+++ b/application/vlc-android/res/xml/preferences_audio.xml
@@ -11,12 +11,6 @@
android:key="resume_playback"
android:summary="@string/resume_playback_summary"
android:title="@string/resume_playback_title"/>
- <CheckBoxPreference
- app:singleLineTitle="false"
- android:defaultValue="false"
- android:key="playback_speed"
- android:summary="@string/playback_speed_summary"
- android:title="@string/playback_speed_title"/>
<CheckBoxPreference
app:singleLineTitle="false"
diff --git a/application/vlc-android/res/xml/preferences_video.xml b/application/vlc-android/res/xml/preferences_video.xml
index 8a05b2f635..19034431d2 100644
--- a/application/vlc-android/res/xml/preferences_video.xml
+++ b/application/vlc-android/res/xml/preferences_video.xml
@@ -16,12 +16,6 @@
android:key="save_brightness"
android:summary="@string/save_brightness_summary"
android:title="@string/save_brightness_title"/>
- <CheckBoxPreference
- app:singleLineTitle="false"
- android:defaultValue="false"
- android:key="playback_speed_video"
- android:summary="@string/playback_speed_summary"
- android:title="@string/playback_speed_title"/>
<CheckBoxPreference
app:singleLineTitle="false"
android:defaultValue="false"
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudio.kt b/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudio.kt
index aa29c25db9..b1dfc32454 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudio.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudio.kt
@@ -42,8 +42,6 @@ import org.videolan.libvlc.util.AndroidUtil
import org.videolan.resources.AndroidDevices
import org.videolan.resources.VLCInstance
import org.videolan.tools.AUDIO_DUCKING
-import org.videolan.tools.KEY_PLAYBACK_RATE
-import org.videolan.tools.KEY_PLAYBACK_SPEED_PERSIST
import org.videolan.tools.LocaleUtils
import org.videolan.tools.RESUME_PLAYBACK
import org.videolan.tools.Settings
@@ -189,7 +187,6 @@ class PreferencesAudio : BasePreferenceFragment(), SharedPreferences.OnSharedPre
} else lifecycleScope.launch { restartLibVLC() }
}
}
- KEY_PLAYBACK_SPEED_PERSIST -> sharedPreferences.putSingle(KEY_PLAYBACK_RATE, 1.0f)
}
}
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesVideo.kt b/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesVideo.kt
index 46dcbb3155..6a17ec917a 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesVideo.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesVideo.kt
@@ -29,8 +29,6 @@ import androidx.preference.Preference
import kotlinx.coroutines.launch
import org.videolan.libvlc.util.AndroidUtil
import org.videolan.resources.VLCInstance
-import org.videolan.tools.KEY_PLAYBACK_RATE_VIDEO
-import org.videolan.tools.KEY_PLAYBACK_SPEED_PERSIST_VIDEO
import org.videolan.tools.POPUP_FORCE_LEGACY
import org.videolan.tools.putSingle
import org.videolan.vlc.R
@@ -72,7 +70,6 @@ class PreferencesVideo : BasePreferenceFragment(), SharedPreferences.OnSharedPre
if (sharedPreferences.getBoolean(key, false) && !Permissions.canDrawOverlays(requireActivity())) Permissions.checkDrawOverlaysPermission(requireActivity())
if (!sharedPreferences.getBoolean(key, false) && !Permissions.isPiPAllowed(requireActivity())) Permissions.checkPiPPermission(requireActivity())
}
- KEY_PLAYBACK_SPEED_PERSIST_VIDEO -> sharedPreferences.putSingle(KEY_PLAYBACK_RATE_VIDEO, 1.0f)
}
}
}
More information about the Android
mailing list