[Android] Fix restoring audio playback when history is off

Nicolas Pomepuy git at videolan.org
Fri Feb 28 10:06:25 UTC 2025


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Feb 27 07:55:05 2025 +0100| [ab1daaca2949e1f4aadf77d4c052aba04fd69e3c] | committer: Nicolas Pomepuy

Fix restoring audio playback when history is off

Fixes #3147

> https://code.videolan.org/videolan/vlc-android/commit/ab1daaca2949e1f4aadf77d4c052aba04fd69e3c
---

 .../vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt      | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt b/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt
index 18d3756da4..f7fa2a7760 100644
--- a/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt
+++ b/application/vlc-android/src/org/videolan/vlc/media/PlaylistManager.kt
@@ -516,8 +516,7 @@ class PlaylistManager(val service: PlaybackService) : MediaWrapperList.EventList
                 }
             } else {
                 start = if (forceRestart
-                    || audioResumeStatus == ResumeStatus.NEVER
-                    || !Settings.getInstance(AppContextProvider.appContext).getBoolean(PLAYBACK_HISTORY, true)) 0L else getStartTime(mw)
+                    || audioResumeStatus == ResumeStatus.NEVER) 0L else getStartTime(mw)
                 if (!forceResume && audioResumeStatus == ResumeStatus.ASK && start > 0 && isAppStarted()) {
                     val confirmation = WaitConfirmation(mw.title, index, flags)
                     waitForConfirmationAudio.postValue(confirmation)
@@ -795,7 +794,7 @@ class PlaylistManager(val service: PlaybackService) : MediaWrapperList.EventList
     }
 
     suspend fun saveMediaList(forceVideo:Boolean = false) {
-        if (settings.getBoolean(KEY_INCOGNITO, false) || !settings.getBoolean(PLAYBACK_HISTORY, true)) return
+        if (settings.getBoolean(KEY_INCOGNITO, false)) return
         val currentMedia = getCurrentMedia() ?: return
         if (currentMedia.uri.scheme.isSchemeFD()) return
         val locations = StringBuilder()
@@ -989,7 +988,7 @@ class PlaylistManager(val service: PlaybackService) : MediaWrapperList.EventList
 
     @Synchronized
     private fun savePosition(reset: Boolean = false, video: Boolean = false) {
-        if (settings.getBoolean(KEY_INCOGNITO, false) || !settings.getBoolean(PLAYBACK_HISTORY, true)) return
+        if (settings.getBoolean(KEY_INCOGNITO, false)) return
         if (!hasMedia()) return
         settings.edit {
             val audio = !video && isAudioList()



More information about the Android mailing list