[Android] Fix bookmarks not appearing in the bookmark delegate

Nicolas Pomepuy git at videolan.org
Fri Feb 28 12:32:39 UTC 2025


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Wed Feb 26 07:32:33 2025 +0100| [e3851bee0f83dda2f194903c5739d61e0339ece5] | committer: Duncan McNamara

Fix bookmarks not appearing in the bookmark delegate

> https://code.videolan.org/videolan/vlc-android/commit/e3851bee0f83dda2f194903c5739d61e0339ece5
---

 .../src/org/videolan/vlc/gui/audio/AudioPlayer.kt          | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt
index 8ddabb2274..a10f98a08a 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt
@@ -436,12 +436,14 @@ class AudioPlayer : Fragment(), PlaylistAdapter.IPlayer, TextWatcher, IAudioPlay
             binding.audioForwardBookmark.setGone()
             binding.audioRewindBookmark.setGone()
         }
-        if (settings.getBoolean(KEY_AUDIO_SHOW_BOOKMARK_MARKERS, false))
-            bookmarkModel.service?.let { service ->
-                binding.bookmarkMarkerContainer.setVisible()
-                BookmarkListDelegate.showBookmarks(binding.bookmarkMarkerContainer, service, requireActivity(), bookmarkModel.dataset.getList())
-            }
-        else binding.bookmarkMarkerContainer.removeAllViews()
+        if (!::bookmarkListDelegate.isInitialized || !bookmarkListDelegate.visible) {
+            if (settings.getBoolean(KEY_AUDIO_SHOW_BOOKMARK_MARKERS, false))
+                bookmarkModel.service?.let { service ->
+                    binding.bookmarkMarkerContainer.setVisible()
+                    BookmarkListDelegate.showBookmarks(binding.bookmarkMarkerContainer, service, requireActivity(), bookmarkModel.dataset.getList())
+                }
+            else binding.bookmarkMarkerContainer.removeAllViews()
+        }
 
         binding.songTitle?.text = if (!chapter.isNullOrEmpty()) chapter else  playlistModel.title
         binding.songSubtitle?.text = if (!chapter.isNullOrEmpty()) TextUtils.separatedString(playlistModel.title, playlistModel.artist) else TextUtils.separatedString(playlistModel.artist, playlistModel.album)



More information about the Android mailing list