[Android] Make bookmark audio buttons and marker enabled by default

[Nicolas Pomepuy]

vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Wed Feb 26 07:53:05 2025 +0100| [f92448b0699d4e7273bea9899027701292857ae8] | committer: Duncan McNamara

Make bookmark audio buttons and marker enabled by default

> https://code.videolan.org/videolan/vlc-android/commit/f92448b0699d4e7273bea9899027701292857ae8
---

 application/vlc-android/res/xml/preferences_audio_controls.xml        | 4 ++--
 application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt | 4 ++--
 .../src/org/videolan/vlc/gui/preferences/PreferencesAudioControls.kt  | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/application/vlc-android/res/xml/preferences_audio_controls.xml b/application/vlc-android/res/xml/preferences_audio_controls.xml
index c7a44f4955..1a98fda4fc 100644
--- a/application/vlc-android/res/xml/preferences_audio_controls.xml
+++ b/application/vlc-android/res/xml/preferences_audio_controls.xml
@@ -53,14 +53,14 @@
                 android:summary="@string/show_chapter_buttons_summary"/>
         <CheckBoxPreference
                 app:singleLineTitle="false"
-                android:defaultValue="false"
+                android:defaultValue="true"
                 android:key="audio_show_bookmark_buttons"
                 android:title="@string/show_bookmark_buttons"
                 android:summary="@string/show_bookmark_buttons_summary"/>
 
         <CheckBoxPreference
                 app:singleLineTitle="false"
-                android:defaultValue="false"
+                android:defaultValue="true"
                 android:dependency="audio_show_bookmark_buttons"
                 android:key="audio_show_bookmark_markers"
                 android:title="@string/show_bookmark_markers"
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt
index a10f98a08a..7210e084a4 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioPlayer.kt
@@ -429,7 +429,7 @@ class AudioPlayer : Fragment(), PlaylistAdapter.IPlayer, TextWatcher, IAudioPlay
             binding.previousChapter?.visibility = View.VISIBLE
         }
 
-        if (isShowingCover() && !bookmarkModel.dataset.isEmpty() && settings.getBoolean(KEY_AUDIO_SHOW_BOOkMARK_BUTTONS, false)) {
+        if (isShowingCover() && !bookmarkModel.dataset.isEmpty() && settings.getBoolean(KEY_AUDIO_SHOW_BOOkMARK_BUTTONS, true)) {
             binding.audioForwardBookmark.setVisible()
             binding.audioRewindBookmark.setVisible()
         } else {
@@ -437,7 +437,7 @@ class AudioPlayer : Fragment(), PlaylistAdapter.IPlayer, TextWatcher, IAudioPlay
             binding.audioRewindBookmark.setGone()
         }
         if (!::bookmarkListDelegate.isInitialized || !bookmarkListDelegate.visible) {
-            if (settings.getBoolean(KEY_AUDIO_SHOW_BOOKMARK_MARKERS, false))
+            if (settings.getBoolean(KEY_AUDIO_SHOW_BOOKMARK_MARKERS, true))
                 bookmarkModel.service?.let { service ->
                     binding.bookmarkMarkerContainer.setVisible()
                     BookmarkListDelegate.showBookmarks(binding.bookmarkMarkerContainer, service, requireActivity(), bookmarkModel.dataset.getList())
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudioControls.kt b/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudioControls.kt
index 314843c9c4..b5db1a4492 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudioControls.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/preferences/PreferencesAudioControls.kt
@@ -71,7 +71,7 @@ class PreferencesAudioControls : BasePreferenceFragment(), SharedPreferences.OnS
                 Settings.audioShowTrackNumbers.postValue(sharedPreferences.getBoolean(KEY_AUDIO_SHOW_TRACK_NUMBERS, false))
             }
             KEY_AUDIO_SHOW_BOOkMARK_BUTTONS -> {
-                if (!sharedPreferences.getBoolean(KEY_AUDIO_SHOW_BOOkMARK_BUTTONS, false)) {
+                if (!sharedPreferences.getBoolean(KEY_AUDIO_SHOW_BOOkMARK_BUTTONS, true)) {
                     bookmarkMarkersPreference.isChecked = false
                 }
             }