[Android] LifecycleAwareScheduler: disable debug logs

Duncan McNamara git at videolan.org
Fri Jan 10 11:07:19 UTC 2025


vlc-android | branch: master | Duncan McNamara <dcn.mcnamara at gmail.com> | Wed Jan  8 17:14:50 2025 +0100| [6de06138c6f8dd3028c0d7a68bfcd687b862ec9f] | committer: Nicolas Pomepuy

LifecycleAwareScheduler: disable debug logs

> https://code.videolan.org/videolan/vlc-android/commit/6de06138c6f8dd3028c0d7a68bfcd687b862ec9f
---

 .../src/org/videolan/vlc/gui/view/FastScroller.kt          |  3 ++-
 .../src/org/videolan/vlc/util/LifecycleAwareScheduler.kt   | 14 +++++++++++---
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/gui/view/FastScroller.kt b/application/vlc-android/src/org/videolan/vlc/gui/view/FastScroller.kt
index aff6a91ba4..ea4a0bffdf 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/view/FastScroller.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/view/FastScroller.kt
@@ -173,7 +173,8 @@ class FastScroller : LinearLayout, Observer<HeadersIndex>, SchedulerCallback, Ap
      * Hides the bubble containing the section letter
      */
     private fun hideBubble() {
-        if (BuildConfig.DEBUG) Log.d("LifecycleAwareScheduler", "hideBubble on thread ${Thread.currentThread()}")
+        if (BuildConfig.DEBUG && LifecycleAwareScheduler.LIFECYLE_LOG_ENABLED)
+            Log.d(LifecycleAwareScheduler.LIFECYCLE_TAG, "hideBubble on thread ${Thread.currentThread()}")
         currentAnimator = AnimatorSet()
         bubble.pivotX = bubble.width.toFloat()
         bubble.pivotY = bubble.height.toFloat()
diff --git a/application/vlc-android/src/org/videolan/vlc/util/LifecycleAwareScheduler.kt b/application/vlc-android/src/org/videolan/vlc/util/LifecycleAwareScheduler.kt
index f457268891..dc4cdd83d5 100644
--- a/application/vlc-android/src/org/videolan/vlc/util/LifecycleAwareScheduler.kt
+++ b/application/vlc-android/src/org/videolan/vlc/util/LifecycleAwareScheduler.kt
@@ -74,7 +74,8 @@ class LifecycleAwareScheduler(private val callback: SchedulerCallback) : Default
     private val timeTasks = HashMap<String, TimerTask>()
 
     init {
-        if (BuildConfig.DEBUG) Log.d("LifecycleAwareScheduler", "Creating LifecycleAwareScheduler for $callback")
+        if (BuildConfig.DEBUG && LIFECYLE_LOG_ENABLED)
+            Log.d(LIFECYCLE_TAG, "Creating LifecycleAwareScheduler for $callback")
     }
 
     /**
@@ -98,7 +99,8 @@ class LifecycleAwareScheduler(private val callback: SchedulerCallback) : Default
      */
     fun scheduleAction(id: String, delay: Long, data:Bundle = Bundle()) {
         if (canceled) return
-        if (BuildConfig.DEBUG) Log.d("LifecycleAwareScheduler", "Scheduling action for $callback on thread ${Thread.currentThread()} with id $id")
+        if (BuildConfig.DEBUG && LIFECYLE_LOG_ENABLED)
+            Log.d(LIFECYCLE_TAG, "Scheduling action for $callback on thread ${Thread.currentThread()} with id $id")
         callback.lifecycle.addObserver(this at LifecycleAwareScheduler)
         if (timeTasks.keys.contains(id)) cancelAction(id)
         timeTasks[id] = timerTask {
@@ -132,7 +134,8 @@ class LifecycleAwareScheduler(private val callback: SchedulerCallback) : Default
      * @return true if an action has been canceled, false otherwise
      */
     fun cancelAction(id: String): Boolean {
-        if (BuildConfig.DEBUG) Log.d("LifecycleAwareScheduler", "Canceling action for $callback on thread ${Thread.currentThread()} with id $id")
+        if (BuildConfig.DEBUG && LIFECYLE_LOG_ENABLED)
+            Log.d(LIFECYCLE_TAG, "Canceling action for $callback on thread ${Thread.currentThread()} with id $id")
         if (timeTasks.keys.contains(id)) {
             timeTasks[id]?.cancel()
             callback.onTaskCancelled(id)
@@ -164,4 +167,9 @@ class LifecycleAwareScheduler(private val callback: SchedulerCallback) : Default
         super.onDestroy(owner)
         discardTimer()
     }
+
+    companion object {
+        const val LIFECYCLE_TAG = "LifecycleAwareScheduler"
+        const val LIFECYLE_LOG_ENABLED = false
+    }
 }
\ No newline at end of file



More information about the Android mailing list