[Android] Fix thumbnails ratio

Nicolas Pomepuy git at videolan.org
Mon Jan 20 11:04:39 UTC 2025


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon Jan 20 11:58:43 2025 +0100| [0d61039ecd7c863a81dabe5c30d771e92d2bce8a] | committer: Nicolas Pomepuy

Fix thumbnails ratio

Fixes #3128

> https://code.videolan.org/videolan/vlc-android/commit/0d61039ecd7c863a81dabe5c30d771e92d2bce8a
---

 .../src/org/videolan/vlc/gui/helpers/ImageLoader.kt            | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/gui/helpers/ImageLoader.kt b/application/vlc-android/src/org/videolan/vlc/gui/helpers/ImageLoader.kt
index f7970937c6..cc3ec364c7 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/helpers/ImageLoader.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/helpers/ImageLoader.kt
@@ -279,13 +279,7 @@ private suspend fun getPlaylistOrGenreImage(v: View, item: MediaLibraryItem, bin
         val tracks = withContext(Dispatchers.IO) { item.tracks.toList() }
         ThumbnailsProvider.getPlaylistOrGenreImage("${if (item is MediaWrapper && item.type == MediaWrapper.TYPE_PLAYLIST)"playlist" else "genre"}:${item.id}_$width", tracks, width)
     } else null
-    val defaultDrawable = if (item is Playlist || (item is MediaWrapper && item.type == MediaWrapper.TYPE_PLAYLIST))
-        if (card) UiTools.getDefaultPlaylistDrawableBig(AppContextProvider.appContext).bitmap else UiTools.getDefaultPlaylistDrawable(AppContextProvider.appContext).bitmap
-    else
-        if (card) UiTools.getDefaultGenreDrawableBig(AppContextProvider.appContext).bitmap else UiTools.getDefaultGenreDrawable(AppContextProvider.appContext).bitmap
-
-    if (!bindChanged && playlistImage == null) playlistImage = defaultDrawable
-    if (!bindChanged && playlistImage == null) binding?.setVariable(BR.showProgress, false)
+    if (playlistImage == null) return
     if (!bindChanged) updateImageView(playlistImage, v, binding, card = card)
 
     binding?.removeOnRebindCallback(rebindCallbacks!!)
@@ -310,7 +304,7 @@ fun updateImageViewTv(@DrawableRes res: Int, target: View) {
 fun updateImageView(bitmap: Bitmap?, target: View, vdb: ViewDataBinding?, updateScaleType: Boolean = true, tv: Boolean = false, card: Boolean = false) {
     if (bitmap === null || bitmap.width <= 1 || bitmap.height <= 1) return
     if (vdb !== null && !tv) {
-        vdb.setVariable(BR.scaleType, if (card) ImageView.ScaleType.CENTER_INSIDE else ImageView.ScaleType.FIT_CENTER)
+        vdb.setVariable(BR.scaleType, if (card) ImageView.ScaleType.CENTER_CROP else ImageView.ScaleType.FIT_CENTER)
         vdb.setVariable(BR.cover, BitmapDrawable(target.resources, bitmap))
         vdb.setVariable(BR.protocol, null)
         vdb.setVariable(BR.showProgress, false)



More information about the Android mailing list