[Android] New equalizer: remove the useless save button

Nicolas Pomepuy git at videolan.org
Fri Jul 25 11:46:42 UTC 2025


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Wed Jun 11 06:33:13 2025 +0200| [09fa4593a1549f341abefa03f92a5e47b3f2ac18] | committer: Nicolas Pomepuy

New equalizer: remove the useless save button

> https://code.videolan.org/videolan/vlc-android/commit/09fa4593a1549f341abefa03f92a5e47b3f2ac18
---

 .../resources/src/main/res/drawable/ic_save.xml    | 35 ----------------------
 .../vlc-android/res/layout/dialog_equalizer.xml    | 19 ------------
 2 files changed, 54 deletions(-)

diff --git a/application/resources/src/main/res/drawable/ic_save.xml b/application/resources/src/main/res/drawable/ic_save.xml
deleted file mode 100644
index 7af439ef01..0000000000
--- a/application/resources/src/main/res/drawable/ic_save.xml
+++ /dev/null
@@ -1,35 +0,0 @@
-<!--
-  ~ *************************************************************************
-  ~  ic_save.xml
-  ~ **************************************************************************
-  ~ Copyright © 2025 VLC authors and VideoLAN
-  ~ Author: Nicolas POMEPUY
-  ~ This program is free software; you can redistribute it and/or modify
-  ~ it under the terms of the GNU General Public License as published by
-  ~ the Free Software Foundation; either version 2 of the License, or
-  ~ (at your option) any later version.
-  ~
-  ~ This program is distributed in the hope that it will be useful,
-  ~ but WITHOUT ANY WARRANTY; without even the implied warranty of
-  ~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-  ~ GNU General Public License for more details.
-  ~
-  ~ You should have received a copy of the GNU General Public License
-  ~ along with this program; if not, write to the Free Software
-  ~ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
-  ~ ***************************************************************************
-  ~
-  ~
-  -->
-
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-        android:width="24dp"
-        android:height="24dp"
-        android:viewportWidth="24"
-        android:viewportHeight="24">
-
-    <path
-            android:fillColor="?attr/colorControlNormal"
-            android:pathData="M17,3L5,3c-1.11,0 -2,0.9 -2,2v14c0,1.1 0.89,2 2,2h14c1.1,0 2,-0.9 2,-2L21,7l-4,-4zM19,19L5,19L5,5h11.17L19,7.83L19,19zM12,12c-1.66,0 -3,1.34 -3,3s1.34,3 3,3 3,-1.34 3,-3 -1.34,-3 -3,-3zM6,6h9v4L6,10z" />
-
-</vector>
diff --git a/application/vlc-android/res/layout/dialog_equalizer.xml b/application/vlc-android/res/layout/dialog_equalizer.xml
index 0506bf1b61..92855498aa 100644
--- a/application/vlc-android/res/layout/dialog_equalizer.xml
+++ b/application/vlc-android/res/layout/dialog_equalizer.xml
@@ -167,25 +167,6 @@
                                 app:srcCompat="@drawable/ic_undo"
                                 app:tint="?attr/colorControlNormal" />
 
-                        <androidx.appcompat.widget.AppCompatImageView
-                                android:id="@+id/save"
-                                android:layout_width="wrap_content"
-                                android:layout_height="wrap_content"
-                                android:layout_marginEnd="8dp"
-                                android:background="?attr/actionBarItemBackground"
-                                android:clickable="true"
-                                android:contentDescription="@string/save"
-                                android:focusable="true"
-                                android:padding="12dp"
-                                android:visibility="@{state.type != 0 ? View.VISIBLE : View.GONE}"
-                                app:layout_constraintBottom_toBottomOf="@+id/top_bar"
-                                app:layout_constraintEnd_toEndOf="parent"
-                                app:layout_constraintHorizontal_bias="0.5"
-                                app:layout_constraintStart_toEndOf="@+id/title"
-                                app:layout_constraintTop_toTopOf="@+id/top_bar"
-                                app:srcCompat="@drawable/ic_save"
-                                app:tint="?attr/colorControlNormal" />
-
                         <androidx.appcompat.widget.AppCompatImageView
                                 android:id="@+id/delete"
                                 android:layout_width="wrap_content"



More information about the Android mailing list