[Android] New equalizer: remove useless logs

[Nicolas Pomepuy]

vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon Jun 23 09:00:58 2025 +0200| [01ccfe8b31bcc38655fd86e2d538544ecc94f0f9] | committer: Nicolas Pomepuy

New equalizer: remove useless logs

> https://code.videolan.org/videolan/vlc-android/commit/01ccfe8b31bcc38655fd86e2d538544ecc94f0f9
---

 .../src/org/videolan/vlc/gui/EqualizerSettingsActivity.kt          | 6 +-----
 .../src/org/videolan/vlc/gui/dialogs/EqualizerFragmentDialog.kt    | 7 -------
 .../src/org/videolan/vlc/viewmodels/EqualizerViewModel.kt          | 6 ------
 3 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/application/vlc-android/src/org/videolan/vlc/gui/EqualizerSettingsActivity.kt b/application/vlc-android/src/org/videolan/vlc/gui/EqualizerSettingsActivity.kt
index 606d0b8c57..e93c0329ff 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/EqualizerSettingsActivity.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/EqualizerSettingsActivity.kt
@@ -26,7 +26,6 @@ import androidx.core.net.toUri
 import androidx.core.widget.addTextChangedListener
 import androidx.databinding.BindingAdapter
 import androidx.databinding.DataBindingUtil
-import androidx.lifecycle.Observer
 import androidx.lifecycle.lifecycleScope
 import androidx.recyclerview.widget.LinearLayoutManager
 import com.google.android.material.appbar.MaterialToolbar
@@ -36,7 +35,6 @@ import org.videolan.resources.util.applyOverscanMargin
 import org.videolan.tools.dp
 import org.videolan.tools.setGone
 import org.videolan.tools.setVisible
-import org.videolan.vlc.BuildConfig
 import org.videolan.vlc.R
 import org.videolan.vlc.databinding.EqualizerSettingItemBinding
 import org.videolan.vlc.databinding.EqualizerSettingsActivityBinding
@@ -53,7 +51,6 @@ import org.videolan.vlc.util.FileUtils
 import org.videolan.vlc.util.JsonUtil
 import org.videolan.vlc.viewmodels.EqualizerViewModel
 import org.videolan.vlc.viewmodels.EqualizerViewModelFactory
-import kotlin.math.absoluteValue
 
 private const val FILE_PICKER_RESULT_CODE = 10000
 
@@ -176,7 +173,7 @@ class EqualizerSettingsActivity : BaseActivity() {
                             }
                         }
                     } catch (e: Exception) {
-                        Log.e("EqualizerSettingsActivity", "onActivityResult: ${e.message}", e)
+                        Log.e("EqualizerSettings", "onActivityResult: ${e.message}", e)
                         UiTools.snacker(this at EqualizerSettingsActivity, getString(R.string.invalid_equalizer_file))
                     }
                 }
@@ -269,7 +266,6 @@ fun EqualizerWithBands.getBitmap(context: Context): Bitmap {
     var x = 0
     bands.sortedBy { it.index }.forEach {
         val heightPc = (it.bandValue + 20) / 40
-        if (BuildConfig.DEBUG) Log.d("BandBitmap", "band value is ${it.bandValue} and height is ${heightPc * 38}")
         canvas.drawRect(Rect(x, imageSize, x + step, imageSize - (66 * heightPc).toInt().dp), paint)
         x += step
     }
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/EqualizerFragmentDialog.kt b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/EqualizerFragmentDialog.kt
index 79bc279ac7..2424bae912 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/EqualizerFragmentDialog.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/EqualizerFragmentDialog.kt
@@ -28,7 +28,6 @@ import android.content.Intent
 import android.os.Bundle
 import android.text.Editable
 import android.text.TextWatcher
-import android.util.Log
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
@@ -55,7 +54,6 @@ import org.videolan.tools.dp
 import org.videolan.tools.isStarted
 import org.videolan.tools.setGone
 import org.videolan.tools.setVisible
-import org.videolan.vlc.BuildConfig
 import org.videolan.vlc.R
 import org.videolan.vlc.databinding.DialogEqualizerBinding
 import org.videolan.vlc.gui.EqualizerSettingsActivity
@@ -109,7 +107,6 @@ class EqualizerFragmentDialog : VLCBottomSheetDialogFragment(), Slider.OnChangeL
             binding.equalizerSettings.setGone()
         }
         viewModel.equalizerEntries.observe(this) {
-            if (BuildConfig.DEBUG) Log.d(TAG, "Received new equalizer entries")
             val newEqualizerSets = it.map { it.equalizerEntry.name }
 
             if (oldEqualiserSets != newEqualizerSets) fillPresets()
@@ -273,7 +270,6 @@ class EqualizerFragmentDialog : VLCBottomSheetDialogFragment(), Slider.OnChangeL
      *
      */
     fun fillBands() {
-        if (BuildConfig.DEBUG) Log.d(TAG, "fillBands")
         eqBandsViews.clear()
         binding.equalizerBands.removeAllViews()
         // bands
@@ -287,7 +283,6 @@ class EqualizerFragmentDialog : VLCBottomSheetDialogFragment(), Slider.OnChangeL
 
             val params = LinearLayout.LayoutParams(LayoutParams.WRAP_CONTENT, LayoutParams.MATCH_PARENT, 1f)
             bar.layoutParams = params
-            if (BuildConfig.DEBUG) Log.d(TAG, "Add new band for ${band.index}")
             eqBandsViews.add(bar)
             bar.setSliderId(View.generateViewId())
             bar.setListener(BandListener(band.index))
@@ -402,7 +397,6 @@ class EqualizerFragmentDialog : VLCBottomSheetDialogFragment(), Slider.OnChangeL
 
 
         override fun onProgressChanged(value: Float, fromUser: Boolean) {
-            if (BuildConfig.DEBUG) Log.d(TAG, "onProgressChanged $index, $value, $fromUser")
             if (!fromUser)
                 return
             viewModel.saveInHistory(index)
@@ -444,7 +438,6 @@ class EqualizerFragmentDialog : VLCBottomSheetDialogFragment(), Slider.OnChangeL
         override fun onStopTrackingTouch() {
             oldBands.clear()
             viewModel.updateEqualizerBands(requireActivity(), newBandList)
-            if (BuildConfig.DEBUG) Log.d(TAG, "onStopTrackingTouch $index")
         }
     }
 
diff --git a/application/vlc-android/src/org/videolan/vlc/viewmodels/EqualizerViewModel.kt b/application/vlc-android/src/org/videolan/vlc/viewmodels/EqualizerViewModel.kt
index 633de6b5ca..bbcbb45e5d 100644
--- a/application/vlc-android/src/org/videolan/vlc/viewmodels/EqualizerViewModel.kt
+++ b/application/vlc-android/src/org/videolan/vlc/viewmodels/EqualizerViewModel.kt
@@ -26,7 +26,6 @@ package org.videolan.vlc.viewmodels
 
 import android.content.Context
 import android.net.Uri
-import android.util.Log
 import androidx.core.content.edit
 import androidx.fragment.app.FragmentActivity
 import androidx.lifecycle.MutableLiveData
@@ -41,10 +40,8 @@ import org.videolan.resources.AndroidDevices
 import org.videolan.tools.KEY_CURRENT_EQUALIZER_ID
 import org.videolan.tools.KEY_EQUALIZER_ENABLED
 import org.videolan.tools.Settings
-import org.videolan.vlc.BuildConfig
 import org.videolan.vlc.PlaybackService
 import org.videolan.vlc.R
-import org.videolan.vlc.gui.dialogs.EqualizerFragmentDialog
 import org.videolan.vlc.gui.helpers.UiTools
 import org.videolan.vlc.gui.helpers.hf.StoragePermissionsDelegate.Companion.getWritePermission
 import org.videolan.vlc.mediadb.models.EqualizerBand
@@ -53,7 +50,6 @@ import org.videolan.vlc.mediadb.models.EqualizerWithBands
 import org.videolan.vlc.repository.EqualizerRepository
 import org.videolan.vlc.util.JsonUtil
 import java.io.File
-import kotlin.math.absoluteValue
 
 /**
  * View model storing data for the equalizer dialog
@@ -110,7 +106,6 @@ class EqualizerViewModel(context: Context, private val equalizerRepository: Equa
      *
      */
     fun saveInHistory(from: Int) {
-        if (BuildConfig.DEBUG) Log.d(EqualizerFragmentDialog.TAG, "saveInHistory: from $from, saving: ${from != lastSaveToHistoryFrom}, history size: ${history.size}")
         if (from != lastSaveToHistoryFrom)
             history.add(getCurrentEqualizer().copy())
         lastSaveToHistoryFrom = from
@@ -122,7 +117,6 @@ class EqualizerViewModel(context: Context, private val equalizerRepository: Equa
      * @return the last equalizer from history
      */
     fun undoFromHistory(context: Context) = viewModelScope.launch(Dispatchers.IO) {
-        if (BuildConfig.DEBUG) Log.d(EqualizerFragmentDialog.TAG, "undoFromHistory: history size: ${history.size}")
         lastSaveToHistoryFrom = -2
         if (history.isEmpty()) return at launch
         needForceRefresh = true