[Android] Fix crash on lower APIs when opening the playback speed dialog

Nicolas Pomepuy git at videolan.org
Thu Mar 6 14:19:45 UTC 2025


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Thu Mar  6 14:49:57 2025 +0100| [200d07031fe2a7e22aae61cf316e4d9d7318923e] | committer: Nicolas Pomepuy

Fix crash on lower APIs when opening the playback speed dialog

Fixes #3170

> https://code.videolan.org/videolan/vlc-android/commit/200d07031fe2a7e22aae61cf316e4d9d7318923e
---

 .../vlc-android/res/layout/dialog_playback_speed.xml   | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/application/vlc-android/res/layout/dialog_playback_speed.xml b/application/vlc-android/res/layout/dialog_playback_speed.xml
index 7741aa7ab7..27d78b9d22 100644
--- a/application/vlc-android/res/layout/dialog_playback_speed.xml
+++ b/application/vlc-android/res/layout/dialog_playback_speed.xml
@@ -91,12 +91,12 @@
                 app:layout_constraintTop_toTopOf="@+id/playback_speed_seek" />
 
 
-        <androidx.appcompat.widget.AppCompatImageButton
+        <androidx.appcompat.widget.AppCompatImageView
                 android:id="@+id/button_speed_minus"
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_marginTop="24dp"
-                android:background="@drawable/round_border"
+                app:background="@drawable/round_border"
                 android:contentDescription="@string/talkback_decrease_speed"
                 android:gravity="center"
                 android:padding="12dp"
@@ -120,11 +120,11 @@
                 app:layout_constraintStart_toEndOf="@+id/button_speed_minus"
                 app:layout_constraintTop_toTopOf="@+id/button_speed_minus" />
 
-        <androidx.appcompat.widget.AppCompatImageButton
+        <androidx.appcompat.widget.AppCompatImageView
                 android:id="@+id/button_speed_plus"
                 android:layout_width="48dp"
                 android:layout_height="48dp"
-                android:background="@drawable/round_border"
+                app:background="@drawable/round_border"
                 android:contentDescription="@string/talkback_increase_speed"
                 android:gravity="center"
                 android:padding="12dp"
@@ -139,7 +139,7 @@
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_marginEnd="4dp"
-                android:background="@drawable/round_border"
+                app:background="@drawable/round_border"
                 android:gravity="center"
                 android:text="0.8"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_1"
@@ -153,7 +153,7 @@
                 android:layout_height="48dp"
                 android:layout_marginStart="4dp"
                 android:layout_marginEnd="4dp"
-                android:background="@drawable/round_border"
+                app:background="@drawable/round_border"
                 android:gravity="center"
                 android:text="1.0"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_125"
@@ -167,7 +167,7 @@
                 android:layout_marginStart="4dp"
                 android:layout_marginTop="24dp"
                 android:layout_marginEnd="4dp"
-                android:background="@drawable/round_border"
+                app:background="@drawable/round_border"
                 android:gravity="center"
                 android:text="1.25"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_15"
@@ -180,7 +180,7 @@
                 android:layout_height="48dp"
                 android:layout_marginStart="4dp"
                 android:layout_marginEnd="4dp"
-                android:background="@drawable/round_border"
+                app:background="@drawable/round_border"
                 android:gravity="center"
                 android:text="1.5"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_2"
@@ -192,7 +192,7 @@
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_marginStart="4dp"
-                android:background="@drawable/round_border"
+                app:background="@drawable/round_border"
                 android:gravity="center"
                 android:text="2.0"
                 app:layout_constraintEnd_toEndOf="@+id/playback_speed_seek"



More information about the Android mailing list