[Android] Fix focus in the playback speed dialog

Nicolas Pomepuy git at videolan.org
Tue May 20 09:45:43 UTC 2025


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Tue May 20 08:39:46 2025 +0200| [fd568c6e5f643cf311601e11386403fd31853c14] | committer: Nicolas Pomepuy

Fix focus in the playback speed dialog

> https://code.videolan.org/videolan/vlc-android/commit/fd568c6e5f643cf311601e11386403fd31853c14
---

 .../res/layout/dialog_playback_speed.xml           | 31 +++++++++++++---------
 1 file changed, 19 insertions(+), 12 deletions(-)

diff --git a/application/vlc-android/res/layout/dialog_playback_speed.xml b/application/vlc-android/res/layout/dialog_playback_speed.xml
index 27d78b9d22..c91fbbf338 100644
--- a/application/vlc-android/res/layout/dialog_playback_speed.xml
+++ b/application/vlc-android/res/layout/dialog_playback_speed.xml
@@ -25,12 +25,12 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_marginTop="16dp"
-                app:singleSelection="true"
-                app:selectionRequired="true"
                 app:checkedButton="@+id/this_media"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
-                app:layout_constraintTop_toBottomOf="@+id/textView12">
+                app:layout_constraintTop_toBottomOf="@+id/textView12"
+                app:selectionRequired="true"
+                app:singleSelection="true">
 
             <com.google.android.material.button.MaterialButton
                     android:id="@+id/this_media"
@@ -51,10 +51,10 @@
                 android:id="@+id/speed_mode_explanation"
                 android:layout_width="0dp"
                 android:layout_height="wrap_content"
-                android:gravity="center"
-                android:layout_marginTop="8dp"
                 android:layout_marginStart="16dp"
+                android:layout_marginTop="8dp"
                 android:layout_marginEnd="16dp"
+                android:gravity="center"
                 android:text="@string/warning_stream_speed"
                 android:textStyle="bold"
                 android:visibility="visible"
@@ -96,8 +96,9 @@
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_marginTop="24dp"
-                app:background="@drawable/round_border"
+                android:background="@drawable/round_border"
                 android:contentDescription="@string/talkback_decrease_speed"
+                android:focusable="true"
                 android:gravity="center"
                 android:padding="12dp"
                 android:textSize="22sp"
@@ -124,8 +125,9 @@
                 android:id="@+id/button_speed_plus"
                 android:layout_width="48dp"
                 android:layout_height="48dp"
-                app:background="@drawable/round_border"
+                android:background="@drawable/round_border"
                 android:contentDescription="@string/talkback_increase_speed"
+                android:focusable="true"
                 android:gravity="center"
                 android:padding="12dp"
                 android:textSize="22sp"
@@ -139,7 +141,8 @@
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_marginEnd="4dp"
-                app:background="@drawable/round_border"
+                android:background="@drawable/round_border"
+                android:focusable="true"
                 android:gravity="center"
                 android:text="0.8"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_1"
@@ -153,7 +156,8 @@
                 android:layout_height="48dp"
                 android:layout_marginStart="4dp"
                 android:layout_marginEnd="4dp"
-                app:background="@drawable/round_border"
+                android:background="@drawable/round_border"
+                android:focusable="true"
                 android:gravity="center"
                 android:text="1.0"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_125"
@@ -167,7 +171,8 @@
                 android:layout_marginStart="4dp"
                 android:layout_marginTop="24dp"
                 android:layout_marginEnd="4dp"
-                app:background="@drawable/round_border"
+                android:background="@drawable/round_border"
+                android:focusable="true"
                 android:gravity="center"
                 android:text="1.25"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_15"
@@ -180,7 +185,8 @@
                 android:layout_height="48dp"
                 android:layout_marginStart="4dp"
                 android:layout_marginEnd="4dp"
-                app:background="@drawable/round_border"
+                android:background="@drawable/round_border"
+                android:focusable="true"
                 android:gravity="center"
                 android:text="1.5"
                 app:layout_constraintEnd_toStartOf="@+id/button_speed_2"
@@ -192,7 +198,8 @@
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_marginStart="4dp"
-                app:background="@drawable/round_border"
+                android:background="@drawable/round_border"
+                android:focusable="true"
                 android:gravity="center"
                 android:text="2.0"
                 app:layout_constraintEnd_toEndOf="@+id/playback_speed_seek"



More information about the Android mailing list