[Android] Remote Access: reuse SecureRandom and fix code range

Nicolas Pomepuy git at videolan.org
Wed Jul 22 14:16:26 UTC 2026


vlc-android | branch: master | Nicolas Pomepuy <nicolas at videolabs.io> | Mon Jul 20 11:36:50 2026 +0200| [b43ad12c7c05177eb05f99b18f530e59f4c41c7b] | committer: Duncan McNamara

Remote Access: reuse SecureRandom and fix code range

> https://code.videolan.org/videolan/vlc-android/commit/b43ad12c7c05177eb05f99b18f530e59f4c41c7b
---

 .../main/java/org/videolan/vlc/remoteaccessserver/RemoteAccessOTP.kt   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/application/remote-access-server/src/main/java/org/videolan/vlc/remoteaccessserver/RemoteAccessOTP.kt b/application/remote-access-server/src/main/java/org/videolan/vlc/remoteaccessserver/RemoteAccessOTP.kt
index 21c1c7ebea..256c27b8d2 100644
--- a/application/remote-access-server/src/main/java/org/videolan/vlc/remoteaccessserver/RemoteAccessOTP.kt
+++ b/application/remote-access-server/src/main/java/org/videolan/vlc/remoteaccessserver/RemoteAccessOTP.kt
@@ -37,6 +37,7 @@ import java.security.SecureRandom
 object RemoteAccessOTP {
 
     private val codes = ArrayList<OTPCode>()
+    private val secureRandom = SecureRandom()
 
     /**
      * generate an [OTPCode] and store it in memory for later use
@@ -50,7 +51,7 @@ object RemoteAccessOTP {
         return otpCode
     }
 
-    fun generateCode(): String = (SecureRandom().nextInt(899999) + 100000).toString()
+    fun generateCode(): String = (secureRandom.nextInt(900000) + 100000).toString()
 
     /**
      * Verify if the code is valid by using the challenge



More information about the Android mailing list