[dvblast-devel] Coverity Scan

JULIAN GARDNER joolzg at btinternet.com
Mon Oct 21 21:23:38 CEST 2013


scan.coverity.com

Ive added dvblast as a project and it has come up with interesting interesting errors, please log in and see what it has found.


Also bitstream has a subtle error


desc_69.h
static inline uint8_t desc69_get_day(const uint8_t *p_desc)
{
    uint8_t i_day = ((p_desc[2] & 0x0f) << 1) | ((p_desc[3] & 0x7f) >> 7); // rrrr1111 1xxxxxxx
    return i_day + 1;
}


should be

static inline uint8_t desc69_get_day(const uint8_t *p_desc)
{
    uint8_t i_day = ((p_desc[2] & 0x0f) << 1) | ((p_desc[3] & 0x80) >> 7); // rrrr1111 1xxxxxxx
    return i_day + 1;
}


joolz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/dvblast-devel/attachments/20131021/5554ef71/attachment.html>


More information about the dvblast-devel mailing list