[libbluray-devel] build: cleanup the whole handling of CFLAGS

[Sean McGovern]

On Tue, Feb 19, 2013 at 6:41 AM, Diego Elio Pettenò <git at videolan.org> wrote:
> libbluray | branch: master | Diego Elio Pettenò <flameeyes at flameeyes.eu> | Thu Feb 14 17:43:44 2013 -0800| [52c28e2f99c03b72065a9b5eef8ab50aefee238d] | committer: Diego Elio Pettenò
>
> build: cleanup the whole handling of CFLAGS
>
> Simplify --enable parameters in configure, and use a more common
> default output.
>
> Use attributes.m4 from xine/feng instead of a custom piece of code
> that uses mktemp.
>
>> http://git.videolan.org/gitweb.cgi/libbluray.git/?a=commit;h=52c28e2f99c03b72065a9b5eef8ab50aefee238d
> ---
>
>  configure.ac             |  111 ++++-------------
>  m4/attributes.m4         |  296 ++++++++++++++++++++++++++++++++++++++++++++++
>  src/Makefile.am          |    7 +-
>  src/examples/Makefile.am |    7 +-
>  4 files changed, 318 insertions(+), 103 deletions(-)
>
> Diff:   http://git.videolan.org/gitweb.cgi/libbluray.git/?a=commitdiff;h=52c28e2f99c03b72065a9b5eef8ab50aefee238d

Hi Diego,

This patch adds -O3 indiscriminately to CFLAGS without checking there
are pre-existing optimization CFLAGS. This results in a command line
with both -O2 and -O3 specified.

Currently, libtool.m4 adds -g -O2 to CFLAGS when using gcc.

This probably needs a macro that does a search and replace on
optimization level CFLAGS.

-- Sean McG.