[libdvbpsi-devel] Section CRC not being checked

[Brad Bitterman]

We were testing libdvbpsi 1.1.0 with an ATSC tuner and found that we were getting corrupted data sometimes for the VCT. After looking at the code we found that the CRC was not being checked. 

In the function dvbpsi_packet_push around line 400 the boolean variable is declared and initialized by calling dvbpsi_has_crc( p_section ). This function uses p_section->b_syntax_indicator to check to see if the CRC should be validated. The p_section->b_syntax_indicator is not initialized until a few lines down. This cause the CRC to never be check. 

I moved the call to dvbpsi_has_crc down after b_syntax_indicator gets initialized and I now see the CRC check happening. Is this correct or is there a reason that the code is the way it is?

Thanks,

Brad Bitterman
bitter at vtilt.com



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/libdvbpsi-devel/attachments/20131002/496b14ee/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mailman.videolan.org/pipermail/libdvbpsi-devel/attachments/20131002/496b14ee/attachment.sig>