[PATCH] Title key cache and minor fixes
adam at yggdrasl.demon.co.uk
adam at yggdrasl.demon.co.uk
Mon Jul 1 12:03:04 CEST 2002
d95hjort at dtek.chalmers.se wrote:
<snip diffs>
> What are you trying to fix here? A small description of how it fails
> whould have made it much simpler to know if this was the right fix.
> Is this for the case of insering a key first in a non empty list?
Sorry... <slaps self> Would help if I'd said. Yes, you're correct.
When inserting a key at the start of a non-empty list, the first list
item was being lost (but not freed). This would lead to:
1) a minor memory leak (as all those "lost" first entries got dropped
each time a seek was done back to an early disc block)
2) lots and lots of repeated entries in the title key cache (since
DVD playing seems to re-read early blocks a lot in menus, etc.)
#2 was what alerted me to the problem in the first place. My apologies
for the poor (non-existent) explanation.
Would it be helpful for me to post a better explanation of the cache
patch to the list?
--
Adam Jones
--
This is the libdvdcss-devel mailing-list, see http://www.videolan.org/libdvdcss/
To unsubscribe, please read http://www.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>
More information about the libdvdcss-devel
mailing list