CACHE (on disk) patch for libdvdcss 1.2.2
Samuel Hocevar
sam at zoy.org
Fri Oct 11 10:17:16 CEST 2002
On Thu, Oct 10, 2002, Christophe Massiot wrote:
> Why hasn't this patch been merged in ?
Because I don't like the code as it is. Not only the coding style
(uses tabs, has braces at weird places), but it also outputs to stderr,
assumes we're using a disk while we could actually be reading a VOB,
assumes we can seek to a given location in the stream without checking
the return value, same for mkdir(), uses a lame malloc(16+4) for fixed
size volatile data that gets freed 3 lines below...
Well the feature is probably good, but the code needs rewriting and
I haven't even had time to test it.
--
Sam.
--
This is the libdvdcss-devel mailing-list, see http://www.videolan.org/libdvdcss/
To unsubscribe, please read http://www.videolan.org/lists.html
If you are in trouble, please contact <postmaster at videolan.org>
More information about the libdvdcss-devel
mailing list