[Diego Biurrun <diego at biurrun.de>] [PATCH] MPlayer changes to libdvdcss

[Joey Parrish]

On Tue, Jul 05, 2005 at 07:55:00PM +0100, Gildas Bazin wrote:
> On Tuesday 05 July 2005 14:30, Christophe Massiot wrote:
> > On Tue, Jul 05, 2005, Wout Mertens wrote:
> > > 
> > > On 05 Jul 2005, at 00:59, Christophe Massiot wrote:
> > > 
> > > >> #if defined( WIN32 )
> > > >>-    /* If device is not "X:", we are actually opening a file. */
> > > >>-    dvdcss->b_file = !psz_device[0] || psz_device[1] != ':' || 
> > > >>psz_device[2];
> > > >>+    dvdcss->b_file = 1;
> > > >>+    /* If device is "X:" or "X:\", we are not actually opening a 
> > > >>file. */
> > > >>+    if (psz_device[0] && psz_device[1] == ':' &&
> > > >>+       (!psz_device[2] || (psz_device[2] == '\\' && !psz_device[3])))
> > > >>+        dvdcss->b_file = 0;
> > > >>
> > > >>     /* Initialize readv temporary buffer */
> > > >>     dvdcss->p_readv_buffer   = NULL;
> > > >
> > > >This breaks reading DVD devices on Win32.
> > > 
> > > Does it? Seems to me that it just adds a check for X:\ ...
> > > 
> > > (Not that I know anything about libdvdcss, I'm just a lurker ;-) )
> > 
> > Sorry, you're right, I misread the patch yesterday night...
> > 
> 
> Except that the X:\ syntax should IMHO be used when you want to read the 
> drive as an image instead of as a DVD device (ie. a shared DVD drive or a 
> copy of a DVD onto an HD, etc...). At least this is the way it's done right 
> now if you feed X:\ to libdvdread+libdvdcss.

But when you associate with a DVD drive in Windows Explorer, you use %L
to get the drive name.  It gives it to you in X:\ form.  Thus I added
this check to MPlayer.

--Joey

-- 
"There are trivial truths and there are great truths.  The opposite of a
trivial truth is plainly false.  The opposite of a great truth is also true."
  --Neils Bohr

-- 
This is the libdvdcss-devel mailing-list, see http://developers.videolan.org/
To unsubscribe, go to: http://developers.videolan.org/lists.html