[libdvdcss-devel] [PATCH] OS/2 support

[Diego Biurrun]

On Sun, Feb 01, 2009 at 10:25:13PM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>> On Sun, Feb 01, 2009 at 09:18:53PM +0900, KO Myung-Hun wrote:
>>   
>>> Any comments ?
>>
>> Some nits that might make this more palatable on this mailing
>> list below:
>>   
>>> --- src/device.c.org	2008-07-13 05:25:34.000000000 +0900
>>> +++ src/device.c	2009-02-01 21:06:16.000000000 +0900
>>> @@ -157,6 +181,28 @@
>>>      kern_return_t kern_result;
>>>      io_iterator_t media_iterator;
>>>      CFMutableDictionaryRef classes_to_match;
>>> +#elif defined( SYS_OS2 )
>>> +#pragma pack( 1 )
>>> +    struct
>>> +    {
>>
>> Place the opening brace on the same line, as in other parts of libdvdcss.
>>   
>
> I'm confused because two styles are mixed in other parts. See 'css.h',  
> 'device.h', 'libdvdcss.h' and so on.

OK

>>> @@ -322,6 +394,18 @@
>>>      }
>>>      else
>>> +#elif defined( SYS_OS2 )
>>> +    /* If device is "X:" or "X:\", we are not actually opening a file. */
>>> +    if (psz_device[0] && psz_device[1] == ':' &&
>>> +       (!psz_device[2] || (psz_device[2] == '\\' && !psz_device[3])))
>>>     
>>
>> again
>
> Those were copied from the above Win32 codes. Still it is problematic, I  
> willing to fix them.

They were probably added by MPlayer patches.  Use the more common style
with spaces.

>>> --- src/libdvdcss.c.org	2008-08-29 11:41:38.000000000 +0900
>>> +++ src/libdvdcss.c	2009-02-01 21:02:18.000000000 +0900
>>> @@ -306,7 +306,25 @@
>>> +
>>> +#       ifdef SYS_OS2
>>> +            if( *psz_home == '/' || *psz_home == '\\')
>
> Ditto.

Again, I think it is better to follow the more common style.

Diego