[libdvdcss-devel] [PATCH] more aggressive dvdcss_test

[Jean-Baptiste Kempf]

On Sat, Sep 25, 2010 at 04:46:49PM +0200, Reimar Döffinger wrote :
> attached patch makes dvdcss_test more agressive by making it only
> set b_scrambled to 0 if it is _absolutely_ certain the disc is
> not encrypted (the per-title checks will detect unscrambled titles
> just fine anyway), never unsetting b_ioctls (which I tested on a disc image
> with b_ioctls always forced to 1, it still works just fine).
> I also removed the return value, since it tried to indicate orthogonal
> things (like RPC state and scrambling) which is just confusing and
> not really behaving right (e.g. printing a misleading debug message
> for the -2 return value that would only duplicate debug info from
> dvdcss_test anyway).
> This fixes the behaviour with some region-free and possibly some hacked drives
> where the RPC status ioctl would not work, causing ioctls to be
> not used at all.
> I guess it might be possible to do this a bit nicer,
> but it is at least better than the current state IMO.

Could an wise elder libdvdcss developer comment on this patch, please?

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device