[libdvdcss-devel] [PATCH] support ELF visibility attribute
Diego Biurrun
diego at biurrun.de
Tue Aug 28 12:08:50 CEST 2012
On Mon, Aug 27, 2012 at 10:57:15AM +0200, Fabian Greffrath wrote:
>
> after another 4 weeks, could someone please review my patch of July
> 11th, re-attached for your convenience?
I forwarded your patch to Diego Pettenò for review, here is his reply:
On 27/08/2012 11:43, Diego Biurrun wrote:
> Here is the autotools patch I was talking about ...
It looks mostly OK. The only thing is that xine and netembryo (part of
LScube) already have a macro to check the flag and attribute so I would
suggest using that, but it should be okay either way.
--
Diego Elio Pettenò — Flameeyes
flameeyes at flameeyes.eu — http://blog.flameeyes.eu/
So if you're willing to go the extra mile that would be great, otherwise
j-b should just go ahead and apply your patch :)
Diego
More information about the libdvdcss-devel
mailing list