[libdvdcss-devel] [PATCH] Re: libdvdcss.so does not distinguish internal from exposed API

[Reimar Döffinger]

On Fri, Jul 06, 2012 at 04:04:41PM +0200, Fabian Greffrath wrote:
> Am 12.03.2012 21:35, schrieb Jean-Baptiste Kempf:
> >You need a modification in configure.ac to check if the compiler
> >supports it.
> >
> >http://svn.xiph.org/trunk/speex/configure.ac
> >http://git.videolan.org/?p=vlc.git;a=blob;f=configure.ac;hb=HEAD
> >
> >Are examples on how to do it.
> 
> I am back late but would like to suggest a new patch to support
> symbol visibility. It is taken more or less from the xiph.org
> implementation and works well on my system.
> 
> I am kindly asking for a review.

Personally I find the linker script approach that FFmpeg uses
preferable.
Though I admit it does not make so much sense since we already
have that LIBDVDCSS_EXPORT code.
Do you know if the configure check does the right thing on MinGW or
cygwin? Those compilers might support both visibility and dllexport
and they might have different semantics.