[libdvdcss-devel] [PATCH 2/2] cygwin: Use Win32 APIs for accessing DVDs

Diego Biurrun diego at biurrun.de
Wed Feb 13 17:30:22 CET 2013


On Wed, Feb 13, 2013 at 03:21:27PM +0100, Jean-Baptiste Kempf wrote:
> On 13 Feb, Diego Biurrun wrote :
> > Signed-off-by: Diego Biurrun <diego at biurrun.de>
> > ---
> >  configure.ac |    3 ---
> >  src/ioctl.c  |   41 +++++++++++++++++++----------------------
> >  src/ioctl.h  |    8 ++++++--
> >  3 files changed, 25 insertions(+), 27 deletions(-)
> 
> To be honest, I don't understand the reasoning and the necessity of this
> patch.

The log message needs to be updated to make this all clearer.

In any case, Cygwin does not naturally define WIN32 and should not be
grouped with MinGW and MSVC as it attempts to be a POSIX system.
Accessing hardware under Windows is a different thing though.
It seems cleaner to group Cygwin together with the WIN32 systems
for that case instead of globally.

Diego


More information about the libdvdcss-devel mailing list