[libdvdcss-devel] [PATCH 2/2] cygwin: Use Win32 APIs for accessing DVDs

[Jean-Baptiste Kempf]

On 13 Feb, Diego Biurrun wrote :
> On Wed, Feb 13, 2013 at 05:36:55PM +0100, Jean-Baptiste Kempf wrote:
> > On 13 Feb, Diego Biurrun wrote :
> > > It seems cleaner to group Cygwin together with the WIN32 systems
> > > for that case instead of globally.
> > 
> > Why not define WIN32 then, in this CYGWIN case?
> > 
> > I mean there is just a difference of include in CYGWIN case, the rest
> > uses the same path everywhere.
> 
> No, there is a much larger difference, look at all the WIN32 ifdefs
> around the code.  I believe it's much safer to enable this specific

Yes, and Cygwin should use all of them, except the 2 io include and the
struct. See ifdef(WIN32) && !CYGWIN.

> case for Cygwin instead of grouping Cygwin together with WIN32, which
> is not correct and thus brittle.  We might stumble over other issues
> in the future.

Sorry, but using Cygwin without Win32 headers to access Win32 devices
is the most stupid thing I have ever heard, since a loong time...

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device