[libdvdcss-devel] [PATCH] Win32: move to WideChars for cache folder

[Reimar Döffinger]

Jean-Baptiste Kempf <jb at videolan.org> wrote:

>On 11 Mar, Reimar Döffinger wrote :
>> I would expect the A variant of the function to return the 8.3
>compatibility file name and it will work just fine.
>
>I don't think that would account for all cases, to be honest. According
>to my limited VLC on Win32 experience, it doesn't.

It's not that I don't believe you, but it would be nice to know where specifically the old code failed.
For example it is possible to turn off support for 8.3 compatibility names.
If this change only affects those systems that makes it a lot less critical and IMHO that would be information that is really nice to have in the commit message.
Of course it's also possible that my assumption of it falling back to 8.3 is wrong.