[libdvdcss-devel] [PATCH] Drop deprecated and useless dvdcss_interface_2 variable from the API

Diego Biurrun diego at biurrun.de
Wed Mar 13 11:54:21 CET 2013


---
 NEWS                |    1 +
 src/dvdcss/dvdcss.h |    5 -----
 src/libdvdcss.c     |   12 ------------
 test/csstest.c      |    3 ---
 test/dvd_region.c   |    3 ---
 5 files changed, 1 insertion(+), 23 deletions(-)

diff --git a/NEWS b/NEWS
index 9290ad6..94d7edb 100644
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,7 @@ Changes between 1.2.13 and 1.3.0:
   * Dropped deprecated, undocumented API:
     - the function dvdcss_title()
     - the type dvdcss_handle
+    - the variable dvdcss_interface_2
   * Drop support for Windows 98 and Windows NT 4.0.
     Windows 98 SE with IE 5.0 and Windows NT 4.0 SP4 with IE 5.0 are required.
 
diff --git a/src/dvdcss/dvdcss.h b/src/dvdcss/dvdcss.h
index f327aa2..7c9c733 100644
--- a/src/dvdcss/dvdcss.h
+++ b/src/dvdcss/dvdcss.h
@@ -65,11 +65,6 @@ typedef struct dvdcss_s* dvdcss_t;
 #define LIBDVDCSS_EXPORT extern
 #endif
 
-/*
- * Our version number. The variable name contains the interface version.
- */
-LIBDVDCSS_EXPORT char *        dvdcss_interface_2;
-
 
 /*
  * Exported prototypes.
diff --git a/src/libdvdcss.c b/src/libdvdcss.c
index a5014b4..2a1a5bb 100644
--- a/src/libdvdcss.c
+++ b/src/libdvdcss.c
@@ -137,18 +137,6 @@
 #endif
 
 /**
- * \brief Symbol for version checks.
- *
- * The name of this symbol contains the library major number, which makes it
- * easy to check which \e libdvdcss development headers are installed on the
- * system with tools such as autoconf.
- *
- * The variable itself contains the exact version number of the library,
- * which can be useful for specific feature needs.
- */
-char * dvdcss_interface_2 = VERSION;
-
-/**
  * \brief Open a DVD device or directory and return a dvdcss instance.
  *
  * \param psz_target a string containing the target name, for instance
diff --git a/test/csstest.c b/test/csstest.c
index 70f3b4d..16300a0 100644
--- a/test/csstest.c
+++ b/test/csstest.c
@@ -23,9 +23,6 @@ int main( int i_argc, char *ppsz_argv[] )
     unsigned int   i_sector;
     int            i_ret;
 
-    /* Print version number */
-    printf( "cool, I found libdvdcss version %s\n", dvdcss_interface_2 );
-
     /* Check for 2 arguments */
     if( i_argc != 3 )
     {
diff --git a/test/dvd_region.c b/test/dvd_region.c
index 8a4730e..47abea8 100644
--- a/test/dvd_region.c
+++ b/test/dvd_region.c
@@ -276,9 +276,6 @@ int main(int argc, char *argv[])
     return -1;
   }
 
-  /* Print version number */
-  printf( "found libdvdcss version %s\n", dvdcss_interface_2 );
-
   /* TODO: use dvdcss_open instead of open */
 
   if( (fd = open(device_name, O_RDONLY | O_NONBLOCK)) < 0 ) {
-- 
1.7.9.5



More information about the libdvdcss-devel mailing list