[libdvdcss-devel] [PATCH 1/4] Replace DVD access method #defines by an enum.

[Jean-Baptiste Kempf]

LGTM.

On 01 Nov, Diego Biurrun wrote :
> ---
>  src/libdvdcss.h | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/src/libdvdcss.h b/src/libdvdcss.h
> index 4f1f4af..399a1a3 100644
> --- a/src/libdvdcss.h
> +++ b/src/libdvdcss.h
> @@ -35,6 +35,14 @@
>  #include "device.h"
>  
>  /*****************************************************************************
> + * libdvdcss method: used like init flags
> + *****************************************************************************/
> +enum dvdcss_method {
> +    DVDCSS_METHOD_KEY,
> +    DVDCSS_METHOD_DISC,
> +    DVDCSS_METHOD_TITLE,
> +};
> +/*****************************************************************************
>   * The libdvdcss structure
>   *****************************************************************************/
>  struct dvdcss_s
> @@ -51,7 +59,7 @@ struct dvdcss_s
>      int ( * pf_readv ) ( dvdcss_t, struct iovec *, int );
>  
>      /* Decryption stuff */
> -    int          i_method;
> +    enum dvdcss_method i_method;
>      css_t        css;
>      int          b_ioctls;
>      int          b_scrambled;
> @@ -78,13 +86,6 @@ struct dvdcss_s
>  };
>  
>  /*****************************************************************************
> - * libdvdcss method: used like init flags
> - *****************************************************************************/
> -#define DVDCSS_METHOD_KEY        0
> -#define DVDCSS_METHOD_DISC       1
> -#define DVDCSS_METHOD_TITLE      2
> -
> -/*****************************************************************************
>   * Functions used across the library
>   *****************************************************************************/
>  #define print_debug( dvdcss, ... ) \
> -- 
> 1.9.1
> 
> _______________________________________________
> libdvdcss-devel mailing list
> libdvdcss-devel at videolan.org
> https://mailman.videolan.org/listinfo/libdvdcss-devel

-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device