[libdvdcss-devel] [PATCH] win32: Do not try to create cache directory in %USERPROFILE%

[Jean-Baptiste Kempf]

On 03 Nov, Diego Biurrun wrote :
> On Mon, Nov 03, 2014 at 02:05:51PM +0100, Jean-Baptiste Kempf wrote:
> > On 03 Nov, Diego Biurrun wrote :
> > > Applications should rather store app-specific data in %APPDATA%.
> > > Furthermore %USERPROFILE% is only referenced in a code branch
> > > that would apply to obsolete Windows versions.
> > 
> > Many enterprise setup still depend on that behaviour.
> 
> What setups are those?
> 
> Note that the code goes like this:
> 
> #if defined(_WIN32_IE) && _WIN32_IE >= 0x500
> ...
> #else
> ...
>    if( psz_home == NULL )
>         psz_home = getenv( "USERPROFILE" );
> ...
> #endif
> 
> So the code is only executed in the non-Windows part of the function since
> _WIN32_IE is set to that value for all Windows toolchains by configure.

OK, then drop it.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device