[libdvdcss-devel] [PATCH 46/47] Drop support for OS/2.

[KO Myung-Hun]

Reimar Döffinger wrote:
> On 6 November 2014 05:16:26 CET, KO Myung-Hun <komh78 at gmail.com> wrote:
>> Diego Biurrun wrote:
>>> On Thu, Oct 30, 2014 at 10:54:34AM +0900, KO Myung-Hun wrote:
>>>> Why ?
>>>
>>> Perhaps you could explain why OS/2 is so intrusive?  It requires
>> ifdefs
>>> in more places than other OSes and does a lot of struct definitions
>> for
>>> stuff that I would expect to be present in system headers.
>>
>> This is the reason why OS/2 should be dropped ? Amazing. 
> 
> I think it should not be dropped, and as Diego mentioned earlier it was not necessarily his intention either, but to start a cost/benefit discussion.
> It is however a reason to ask for the code to be reviewed and if possible to be cleaned up.
> While it is possible OS/2 support needs all that complexity, I think Diego suspects that it's just a case of it being badly implemented.
> 
>> you could show me the unnecessary codes of those ? And it is the
>> problem
>> to define structs because system headers do not provide them ?
> 
> No, but it would be a problem if some structs are defined even though the system headers do provide them or equivalents. I don't know if that is the case, but Diego seems to suspect that (I am not so sure, some of those system headers are very old and probably low-quality code so it's likely they do things that make no sense).
> 

I agree with you. And I have no objections to Diego's work cleaning up
and re-structuring codes at all. But dropping support is different
problem, although Diego's real intention is not so.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr