[libdvdcss-devel] [PATCH 1/7] Clean up and simplify raw device support.

Jean-Baptiste Kempf jb at videolan.org
Sun Nov 16 20:52:57 CET 2014


On 16 Nov, Diego Biurrun wrote :
> On Sun, Nov 16, 2014 at 08:44:13PM +0100, Jean-Baptiste Kempf wrote:
> > On 16 Nov, Diego Biurrun wrote :
> > > Treat access to raw devices just like accessing any other device instead of
> > > providing different semantics. libdvdcss now tries raw devices on all OSes
> > > and bails out instead of continuing if accessing a raw device failed.
> > 
> > I'm not so sure about that, tbh.
> > 
> > Aren't you breaking some use cases?
> 
> Not sure which use cases you might mean.
> 
> Yes, this changes behavior, intentionally.  If raw device access is requested
> and accessing the device fails, we bail out.  Previously libdvdcss would
> continue.  However, I consider the new behavior more sensible.  If you want
> raw access, silent fallback is no good IMO.

Why not fallback but with a warning?

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the libdvdcss-devel mailing list