[libdvdcss-devel] le grande cleanup

[Diego Biurrun]

Bon soir mesdames et messieurs, I 'ave a grande patch set for vous.

I cleaned up libdvdcss as well as I could.  This still needs some
testing, but we're really getting somewhere.  So far I only compiled
it on Linux, Cygwin, and MSVC.

Creating and initializing of the cache directories seems buggy.  The
tag file is created before the cache directory.  Sounds like it always
used to fail and the tag file was created on the second call a program
made to dvdcss_open().

Speaking of dvdcss_open(), I cut it down from 500 lines to something
more sane.  libdvdcss is starting to look sane overall; I'm happy.

No, I don't plan to drop support for all those legacy OSes.  Those are
troll patches that tell you how much extra code each OS needs:

    Drop support for Solaris.
 9 files changed, 6 insertions(+), 320 deletions(-)

    Drop support for OS/2.
 9 files changed, 6 insertions(+), 364 deletions(-)

    Drop support for QNX.
 6 files changed, 5 insertions(+), 183 deletions(-)

    Drop support for BeOS.
 7 files changed, 11 insertions(+), 181 deletions(-)

    Drop support for Windows 9x.
 7 files changed, 11 insertions(+), 620 deletions(-)

I think Windows 9x should go for sure.  The others we can discuss.

cordialement, Diegó


[PATCH 01/46] attributes.m4: Properly declare parameterless main()
[PATCH 02/46] attributes.m4: Drop extra quoting from config.h text in
[PATCH 03/46] Replace "char const" by "const char".
[PATCH 04/46] Mark strings as const where appropriate.
[PATCH 05/46] Drop unnecessary NULL check before free().
[PATCH 06/46] error: Drop unused and disabled _print_debug function.
[PATCH 07/46] error: Drop unnecessary #includes.
[PATCH 08/46] error: Drop unnecessary macro indirection for
[PATCH 09/46] Drop leading underscore from externally visible
[PATCH 10/46] solaris: Drop no use or single use macros
[PATCH 11/46] device: Eliminate nonsense conditional test
[PATCH 12/46] Drop support for Windows 9x.
[PATCH 13/46] indentation cosmetics (for squashing)
[PATCH 14/46] Rename win_readv() to win2k_readv for consistency.
[PATCH 15/46] ioctl: Replace magic number by DVDCSS_BLOCK_SIZE macro
[PATCH 16/46] typo fixes
[PATCH 17/46] Comment some #endifs for increased readability.
[PATCH 18/46] ioctl: cosmetics: Coalesce some macro and declaration
[PATCH 19/46] ioctl: Add missing header to fix standalone compilation
[PATCH 20/46] build: Add $(EXEEXT) to tools shorthand to fix build on
[PATCH 21/46] dvd_region: #include ioctl.c instead of linking against
[PATCH 22/46] dvd_region: Use dvdcss_open() instead of plain open()
[PATCH 23/46] device: Use correct type for ReadFile() function
[PATCH 24/46] device: Move Win32-specific fallback macro to common.h
[PATCH 25/46] device: Refactor a number of block size calculations
[PATCH 26/46] Remove bogus error checking of dvdcss_close_device()
[PATCH 27/46] Replace GCC-specific bits in print_debug macro by
[PATCH 28/46] css: Check the return value of a malloc() invocation
[PATCH 29/46] msvc: Map some POSIX function names to their ISO C++
[PATCH 30/46] ioctl: Initialize variable before use in
[PATCH 31/46] device: Check return value of snprintf() in
[PATCH 32/46] libdvdcss: Drop unnecessary void* pointer casts
[PATCH 33/46] libdvdcss: Avoid a cast when comparing the return
[PATCH 34/46] libdvdcss: Factor out setting library verbosity from
[PATCH 35/46] libdvdcss: Refactor error handling in dvdcss_open()
[PATCH 36/46] libdvdcss: Factor out setting DVD access method from
[PATCH 37/46] libdvdcss: Factor out setting cache directory from
[PATCH 38/46] libdvdcss: Improve some comments in dvdcss_open()
[PATCH 39/46] libdvdcss: Factor out writing cache directory tag from
[PATCH 40/46] libdvdcss: Factor out creating cache directory from
[PATCH 41/46] Add QNX to list of supported OSes.
[PATCH 42/46] Update NEWS file with latest changes.
[PATCH 43/46] Drop support for BeOS.
[PATCH 44/46] Drop support for QNX.
[PATCH 45/46] Drop support for OS/2.
[PATCH 46/46] Drop support for Solaris.