[libdvdcss-devel] le grande cleanup

[Jean-Baptiste Kempf]

On 30 Oct, Diego Biurrun wrote :
> On Thu, Oct 30, 2014 at 02:01:28PM +0100, Jean-Baptiste Kempf wrote:
> > On 29 Oct, Diego Biurrun wrote :
> > > I think Windows 9x should go for sure.  The others we can discuss.
> > 
> > Be careful: what is called here "Win9x" is in fact Adaptec SCSI
> > interface and runs also on Windows XP.
> 
> I was wondering myself due to the "ASPI" in the names.  That still leaves
> the question of whether or not this code is worth keeping.

I'm not sure we should keep it, tbh.
At worse, it's in the git.

> On Windows XP
> the other access method is available, isn't it?

Yes.

> > > [PATCH 43/46] Drop support for BeOS.
> > > [PATCH 44/46] Drop support for QNX.
> > > [PATCH 45/46] Drop support for OS/2.
> > > [PATCH 46/46] Drop support for Solaris.
> > 
> > I think this is not the way to go:
> > The way to go is to split this code in different files, one per OS, with
> > a common code calling the OS-specific functions so that supporting the rarest
> > OSes does not burden the maintenance of the other ones.
> 
> I have had this very thought myself.  Maybe I'll get to it.

It feels cleaner, to me, and as libdvdcss is not that big piece of code,
it wouldn't hurt too much to keep other OSes in.

But I agree 1000x that the ifdef mess we have must go away.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device