[libdvdnav-devel] [PATCH] nav_print: Remove printing bogus value for vobu_uop_ctl

Jean-Baptiste Kempf jb at videolan.org
Thu Jan 2 23:28:20 CET 2014


On 02 Jan, Diego Biurrun wrote :
> navPrint_PCI_GI() prints the values of a pci_gi_t struct, but for the embedded
> user_ops_t substruct it just prints the first 32 bytes by pointer type punning.
> Given that the latter is a large struct with members of system-dependent sizes
> the result of this is often enough just a random value, so drop printing the
> value altogether.
> 
> src/nav_print.c:39:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]

LGTM.

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the libdvdnav-devel mailing list