[mpris] [RFC] MPRIS2 Release Candidate

[Lennart Poettering]

On Fri, 30.07.10 19:26, Mirsal Ennaime (mirsal.ennaime at gmail.com) wrote:

> 
> On Fri, Jul 30, 2010 at 7:15 PM, Johannes Sasongko <sasongko at gmail.com> wrote:
> > Oh, and just throwing an idea out there, would SetVolume(int value) be
> > preferable to AdjustVolume(int diff)?
> 
> "Volume" is a read / write property, so there is no need for a SetVolume method.
> AdjustVolume allows client to avoid a dbus round trip in some cases.

But uh, given that the unit of the volume is unspecified it's kinda
weird having the client programmer choose a delta step here. What should
he pick? 0.1? 0.05? 0.2? 0.15? it's completely arbitrary.

I believe it would make more sense to have one function that allows to
set the volume as an absolute value, plus possibly two simple functions
"VolumeUp" and "VolumeDown" that change the volume relatively, and
define the used volume step internally. That way it is under control of
the mpris server implementor to define the steps used, not the clients.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.