[streaming] RTP payloadtype bug in miniSAPserver

[Derk-Jan Hartman]

Since some time now I have been aware of a HUGE bug in miniSAPserver. 
It creates announces with m= video port udp 14

This essentially means it is announcing video streams which are RTP 
packetized like MP3 streams.... This bug has remained unnoticed to us, 
because essentially the SAP parser in VLC media player is very bad. 
This parser assumes that any single stream (only one m= line) with UDP 
in it must be a MPEG2 TS stream no matter what the RTP payload format 
is set to.

In order to correctly announce VLS streams, the attached patch is 
required. Unfortunately miniSAPserver is in quite a bad shape ATM, and 
many in the VL team have come to recognize that it is essentially a 
very bad piece of software. Work may therefore not continue on it, 
since it would require quite a major overhaul.

However since this has been annoying me so much, and since I hate 
non-compliant stuff, even more so when we ourselves are the guilty 
party, I have done some work on it. One thing led to another and there 
you go some other changes as well :)

* Upped the version number to 0.2.4
* Fixed a missing newline in the -h help
* Bugfix in RTP payloadformat announce (now uses 33 instead of 14)
* Added a config option to set the SAP delay
* Added a=tool parameter so miniSAPserver can be more easily recognized 
(good for bugfixing :)
* Added a=mux:m2t and a=packetformat:RAW parameters (not required, but 
some players like these. VBrick player comes to mind)
* Changed a=plgroup to a=x-plgroup because it is a non standardized 
parameter (new style will be supported by VLC 0.7.3 and up)
* Updated the manpage
* Clarified that miniSAPserver is only supposed to work for MPEG TS 
streams.

ATM, it is not possible to edit using Version Control for 
miniSAPserver, because it isn't in Subversion yet, and CVS cannot be 
edited anymore (as far as I know).
So the patch is attached and I suggest we make a new release with these 
changes ASAP, regardless of wether it is in version control yet.

DJ

---
Universiteit Twente
Derk-Jan Hartman (d.hartman at student.utwente dot nl)
http://home.student.utwente.nl/d.hartman


-------------- next part --------------
A non-text attachment was scrubbed...
Name: mSAPs.patch
Type: application/octet-stream
Size: 8178 bytes
Desc: not available
Url : http://mailman.videolan.org/pipermail/streaming/attachments/20040721/f7a4550b/attachment.obj