[streaming] MiniSAPserver port to Solaris 10

Saso Kiselkov skiselkov at gmail.com
Thu Mar 5 08:10:09 CET 2009


I see you've already implemented the change I was about to propose: 
leave the argument at "int" and only cast to "unsigned char" when needed.

--
Saso

Rémi Denis-Courmont wrote:
> Le lundi 2 mars 2009 10:37:06 Saso Kiselkov, vous avez écrit :
>   
>>  - Change the argument to setsockopt when setting IP_MULTICAST_TTL to
>> "unsigned char" instead of "int".  Turns out Solaris is a bit more
>> pedantic about this than Linux (both define it as u_char, but Linux
>> accepts other types as well, whereas Solaris refuses with EINVAL). I
>> renamed the argument in Broadcast() from i_ttl to c_ttl as well, hoping
>> to follow videolan coding standards correctly.
>>     
>
> This is incorrect. RFC3493 clearly states that the hop limit must be an 
> integer. A char cannot distinguish the default value -1 from the manual 
> values 0-255 range. I fixed it anyway.
>
>   



More information about the streaming mailing list