[vlc-commits] commit: Always call _exit() at end to avoid buggy exit handlers ( Rémi Denis-Courmont )

git at videolan.org git at videolan.org
Sun Aug 8 22:06:47 CEST 2010


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Aug  8 23:06:02 2010 +0300| [725cf4eb04ab02491301a83d8ce6a5c3f5d80794] | committer: Rémi Denis-Courmont 

Always call _exit() at end to avoid buggy exit handlers

Removes the KDE scheduler hack.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=725cf4eb04ab02491301a83d8ce6a5c3f5d80794
---

 bin/vlc.c |   15 ++++-----------
 1 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/bin/vlc.c b/bin/vlc.c
index 25fcf51..7a84ab7 100644
--- a/bin/vlc.c
+++ b/bin/vlc.c
@@ -242,15 +242,8 @@ out:
     for (int i = 1; i < argc; i++)
         LocaleFree (argv[i]);
 
-#ifdef RTLD_NOLOAD
-    /* Avoid crash in KIO scheduler cleanup. */
-    /* This is ugly, but we get way too many crash reports due to this. */
-    if (dlopen ("libkio.so.5", RTLD_LAZY|RTLD_LOCAL|RTLD_NOLOAD) != NULL)
-    {
-        fprintf (stderr, "KIO present. Unclean shutdown!\n"
-           " (see http://bugs.kde.org/show_bug.cgi?id=234484 for details)\n");
-        _exit (0);
-    }
-#endif
-    return 0;
+    /* Do not run exit handlers. Some of them are buggy (e.g. KDE IO scheduler)
+     * and crash. Also some will crash because their library may be already
+     * unloaded (dlclose()). */
+    _exit (0);
 }



More information about the vlc-commits mailing list